From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sandeen.net ([63.231.237.45]:55026 "EHLO sandeen.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726559AbfANRqS (ORCPT ); Mon, 14 Jan 2019 12:46:18 -0500 Subject: Re: [PATCH 2/5] xfs_metadump: Zap multi fsb blocks References: <20190107201355.18996-1-stefanrin@gmail.com> <20190107201355.18996-3-stefanrin@gmail.com> <2b4718eb-bf55-600e-2a42-1b3128bf21bf@sandeen.net> From: Eric Sandeen Message-ID: Date: Mon, 14 Jan 2019 11:46:16 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Stefan Ring Cc: linux-xfs@vger.kernel.org On 1/14/19 11:42 AM, Stefan Ring wrote: > On Fri, Jan 11, 2019 at 6:31 PM Eric Sandeen wrote: >> >> On 1/7/19 2:13 PM, Stefan Ring wrote: >>> Using basically the same code as in process_single_fsb_objects. >>> >>> Signed-off-by: Stefan Ring >> >> thanks, the change here to goto write: looks good to me. >> >> Reviewed-by: Eric Sandeen > > Thanks, this makes my series fully reviewed. Is there anything left > for me to do now? FWIW, I added the Reviewed-by tag and pushed it to > . > I don't think so. Pretty sure the failures I ran into with my extended xfstests harness are actually pre-existing, and Carlos is looking at the root cause. I'll give it another once-over but I hope/plan to include this in xfsprogs-4.20 now. Apologies for the long wait, I can't tell you how much I appreciate your effort on this. Thank you! -Eric