Re: [PATCH 4/7] xfs: rename xfs_zone_gc_iter_next to xfs_zone_gc_iter_irec

Carlos Maiolino
2026-03-30T12:26:35Z

On Mon, Mar 30, 2026 at 07:44:14AM +0200, Christoph Hellwig wrote:
> This function returns the current iterator position, which makes the
> _next postfix a bit misleading.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

> ---
> fs/xfs/xfs_zone_gc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_zone_gc.c b/fs/xfs/xfs_zone_gc.c
> index 273c496c2f1c..3723f5293a64 100644
> --- a/fs/xfs/xfs_zone_gc.c
> +++ b/fs/xfs/xfs_zone_gc.c
> @@ -374,7 +374,7 @@ xfs_zone_gc_query(
> }
>
> static bool
> -xfs_zone_gc_iter_next(
> +xfs_zone_gc_iter_irec(
> struct xfs_mount *mp,
> struct xfs_zone_gc_iter *iter,
> struct xfs_rmap_irec *chunk_rec,
> @@ -691,7 +691,7 @@ xfs_zone_gc_start_chunk(
> if (xfs_is_shutdown(mp))
> return false;
>
> - if (!xfs_zone_gc_iter_next(mp, iter, &irec, &ip))
> + if (!xfs_zone_gc_iter_irec(mp, iter, &irec, &ip))
> return false;
> oz = xfs_zone_gc_alloc_blocks(data, &irec.rm_blockcount, &daddr,
> &is_seq);
> --
> 2.47.3
>
>