Re: [PATCH 1/1] mdrestore: fix restore_v2() superblock length check

[Eric Sandeen <sandeen@redhat.com>]

On 12/10/25 12:00 AM, Christoph Hellwig wrote:
> On Tue, Dec 09, 2025 at 09:28:43PM -0800, Christoph Hellwig wrote:
>> On Tue, Dec 09, 2025 at 12:50:17PM -0800, Darrick J. Wong wrote:
>>>> -	if (xme.xme_addr != 0 || xme.xme_len == 1 ||
>>>> +	if (xme.xme_addr != 0 || cpu_to_be32(xme.xme_len) != 1 ||
>>>
>>> xme.xme_len is the ondisk value, so that should be be32_to_cpu().
>>>
>>> Otherwise the patch looks ok.
>>
>> We really need to bring back regular sparse runs on the userspace
>> code.  Let's see if I can get it back working..
> 
> I just gave it a try, and make CC=cgcc still works in theory.
> But between the urcu headers making it throw up, issues in the
> Linux UAPI headers and our own redefinition of the __be32/__be16
> types it generates so much noise that it stops reporting before
> any real issues including this one.  Sigh.  I'll see if there
> is a way to clean some of this up and get useful results.
> 

"make C=1 / C=2" worked once but when I ran it after seeing this patch,
it didn't seem to catch any errors. It spewed a lot of other things
though, as you mention (urcu, ugh).

I didn't realize that those results could swamp out other reports. :(

-Eric