linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Reichl <preichl@redhat.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Eric Sandeen <sandeen@sandeen.net>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH v9 4/4] xfs: replace mrlock_t with rw_semaphores
Date: Thu, 8 Oct 2020 15:55:16 +0200	[thread overview]
Message-ID: <eebc3029-beb3-5b49-08d4-33ae63085411@redhat.com> (raw)
In-Reply-To: <20201007215545.GA6540@magnolia>


>> Hi,
>>
>> thanks for the comments, however for some reason I cannot reproduce
>> the same memory corruption you are getting.
> 
> <shrug> Do you have full preempt enabled?

Hi, I'm not proud to admit that until now I tested w/o 'CONFIG_PREEMPT=y' :-/
However at least now I can see the bug you hit and test that the proposed change in version #10 fixes that.


> 
>> Do you think that moving the 'rwsem_release()' right before the
>> 'complete()' should fix the problem?
>>
>> Something like:
>>
>>
>> +       /*
>> +        * Update lockdep's lock ownership information to point to
>> +        * this thread as the thread that scheduled this worker is waiting
>> +        * for it's completion.
> 
> Nit: "it's" is always a contraction of "it is"; "its" is correct
> (posessive) form here.

Thanks for noticing. I know the difference...but still I did this mistake. I must focus more next time.

> 
> Otherwise, this looks fine to me.

Thanks, version #10 is on list now.

Bye.


  reply	other threads:[~2020-10-08 13:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-06 19:15 [PATCH v9 0/4] xfs: Remove wrappers for some semaphores Pavel Reichl
2020-10-06 19:15 ` [PATCH v9 1/4] xfs: Refactor xfs_isilocked() Pavel Reichl
2020-10-06 19:15 ` [PATCH v9 2/4] xfs: clean up whitespace in xfs_isilocked() calls Pavel Reichl
2020-10-06 19:15 ` [PATCH v9 3/4] xfs: xfs_isilocked() can only check a single lock type Pavel Reichl
2020-10-06 19:15 ` [PATCH v9 4/4] xfs: replace mrlock_t with rw_semaphores Pavel Reichl
2020-10-07  1:21   ` Darrick J. Wong
2020-10-07 14:17     ` Eric Sandeen
2020-10-07 15:25       ` Darrick J. Wong
2020-10-07 21:15         ` Pavel Reichl
2020-10-07 21:55           ` Darrick J. Wong
2020-10-08 13:55             ` Pavel Reichl [this message]
2020-10-08 16:16               ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eebc3029-beb3-5b49-08d4-33ae63085411@redhat.com \
    --to=preichl@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=sandeen@sandeen.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).