From: Allison Collins <allison.henderson@oracle.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>, sandeen@sandeen.net
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/4] mkfs.xfs: tweak wording of external log device size complaint
Date: Thu, 10 Sep 2020 19:57:47 -0700 [thread overview]
Message-ID: <ef05e7f2-840e-9dbb-8325-7f434bc91e7e@oracle.com> (raw)
In-Reply-To: <159950110270.567664.7772913999736955021.stgit@magnolia>
On 9/7/20 10:51 AM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> If the external log device is too small to satisfy minimum requirements,
> mkfs will complain about "external log device 512 too small...". That
> doesn't make any sense, so add a few missing words to clarify what we're
> talking about:
>
> "external log device size 512 blocks too small..."
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Looks ok
Reviewed-by: Allison Collins <allison.henderson@oracle.com>
> ---
> mkfs/xfs_mkfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index a687f385a9c1..39fad9576088 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -3095,7 +3095,7 @@ calculate_log_size(
> if (!cfg->loginternal) {
> if (min_logblocks > cfg->logblocks) {
> fprintf(stderr,
> -_("external log device %lld too small, must be at least %lld blocks\n"),
> +_("external log device size %lld blocks too small, must be at least %lld blocks\n"),
> (long long)cfg->logblocks,
> (long long)min_logblocks);
> usage();
>
next prev parent reply other threads:[~2020-09-11 2:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 17:51 [PATCH 0/4] xfsprogs: various fixes for 5.9 Darrick J. Wong
2020-09-07 17:51 ` [PATCH 1/4] man: install all manpages that redirect to another manpage Darrick J. Wong
2020-09-08 14:34 ` Christoph Hellwig
2020-09-09 19:11 ` Darrick J. Wong
2020-09-11 2:57 ` Allison Collins
2020-09-07 17:51 ` [PATCH 2/4] mkfs.xfs: tweak wording of external log device size complaint Darrick J. Wong
2020-09-08 14:36 ` Christoph Hellwig
2020-09-11 2:57 ` Allison Collins [this message]
2020-09-07 17:51 ` [PATCH 3/4] mkfs: fix reflink/rmap logic w.r.t. realtime devices and crc=0 support Darrick J. Wong
2020-09-08 14:38 ` Christoph Hellwig
2020-09-11 2:57 ` Allison Collins
2020-09-07 17:51 ` [PATCH 4/4] mkfs: set required parts of the realtime geometry before computing log geometry Darrick J. Wong
2020-09-08 14:40 ` Christoph Hellwig
2020-09-09 19:12 ` Darrick J. Wong
2020-09-11 2:58 ` Allison Collins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef05e7f2-840e-9dbb-8325-7f434bc91e7e@oracle.com \
--to=allison.henderson@oracle.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox