From: Yongpeng Yang <yangyongpeng.storage@gmail.com>
To: Matthew Wilcox <willy@infradead.org>,
"Darrick J. Wong" <djwong@kernel.org>
Cc: Yongpeng Yang <yangyongpeng.storage@gmail.com>,
Namjae Jeon <linkinjeon@kernel.org>,
Sungjong Seo <sj1557.seo@samsung.com>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Jan Kara <jack@suse.cz>, Carlos Maiolino <cem@kernel.org>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Yongpeng Yang <yangyongpeng@xiaomi.com>
Subject: Re: [PATCH] fix missing sb_min_blocksize() return value checks in some filesystems
Date: Sun, 2 Nov 2025 22:53:57 +0800 [thread overview]
Message-ID: <ef70adab-ed59-45c7-b6f0-93b61fdb620b@gmail.com> (raw)
In-Reply-To: <aQTpLEHURCmkpU3K@casper.infradead.org>
On 11/1/2025 12:51 AM, Matthew Wilcox wrote:
> On Fri, Oct 31, 2025 at 08:23:24AM -0700, Darrick J. Wong wrote:
>> Hrmm... sb_min_blocksize clamps its argument (512) up to the bdev lba
>> size, which could fail. That's unlikely given that XFS sets FS_LBS and
>> there shouldn't be a file->private_data; but this function is fallible
>> so let's not just ignore the return value.
>
> Should sb_min_blocksize() be marked __must_check ?
Thanks for the review. I'll add the __must_check mark to
sb_min_blocksize() and include the Fixes tag in v2.
Yongpeng,
prev parent reply other threads:[~2025-11-02 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 14:15 [PATCH] fix missing sb_min_blocksize() return value checks in some filesystems Yongpeng Yang
2025-10-31 15:23 ` Darrick J. Wong
2025-10-31 16:51 ` Matthew Wilcox
2025-11-02 14:53 ` Yongpeng Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef70adab-ed59-45c7-b6f0-93b61fdb620b@gmail.com \
--to=yangyongpeng.storage@gmail.com \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jack@suse.cz \
--cc=linkinjeon@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=willy@infradead.org \
--cc=yangyongpeng@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).