Re: [PATCH V2] xfs: add selinux labels to whiteout inodes

[Eric Sandeen <sandeen@redhat.com>]

On 6/22/22 6:30 PM, Darrick J. Wong wrote:
> On Mon, Jun 20, 2022 at 08:38:36PM -0500, Eric Sandeen wrote:
>> We got a report that "renameat2() with flags=RENAME_WHITEOUT doesn't
>> apply an SELinux label on xfs" as it does on other filesystems
>> (for example, ext4 and tmpfs.)  While I'm not quite sure how labels
>> may interact w/ whiteout files, leaving them as unlabeled seems
>> inconsistent at best. Now that xfs_init_security is not static,
>> rename it to xfs_inode_init_security per dchinner's suggestion.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> Reviewed-by: Dave Chinner <dchinner@redhat.com>
> 
> Looks fine to me.  I wondered slightly if the label creation needs to be
> atomic with the file creation, but quickly realized that /never/
> happens.  Assuming this isn't high priority 5.19 stuff, I'll just roll
> this into 5.20 if that's ok?
> 
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>

Thanks Darrick. I don't think it's high priority, I got a bug report about
the behavior, but there was no indication that it was actively causing
visible problems.

-Eric