Re: [PATCH] iversion: update comments with info about atime updates

Jeff Layton
2022-08-23T14:35:58Z

On Tue, 2022-08-23 at 21:38 +1000, NeilBrown wrote:
> On Tue, 23 Aug 2022, Jeff Layton wrote:
> > So, we can refer to that and simply say:
> >
> > "If the function updates the mtime or ctime on the inode, then the
> > i_version should be incremented. If only the atime is being updated,
> > then the i_version should not be incremented. The exception to this rule
> > is explicit atime updates via utimes() or similar mechanism, which
> > should result in the i_version being incremented."
>
> Is that exception needed? utimes() updates ctime.
>
> https://man7.org/linux/man-pages/man2/utimes.2.html
>
> doesn't say that, but
>
> https://pubs.opengroup.org/onlinepubs/007904875/functions/utimes.html
>
> does, as does the code.
>

Oh, good point! I think we can leave that out. Even better!
--
Jeff Layton <jlayton@kernel.org>