From: Hans Holmberg <Hans.Holmberg@wdc.com>
To: hch <hch@lst.de>, Carlos Maiolino <cem@kernel.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH 3/3] xfs: reject swapon for inodes on a zoned file system earlier
Date: Mon, 18 Aug 2025 13:06:16 +0000 [thread overview]
Message-ID: <f3edf33b-b2b5-4b8f-aa48-3b2b868a9e77@wdc.com> (raw)
In-Reply-To: <20250818050716.1485521-4-hch@lst.de>
On 18/08/2025 07:07, Christoph Hellwig wrote:
> No point in going down into the iomap mapping loop when we known it
> will be rejected.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/xfs/xfs_aops.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index 1ee4f835ac3c..a26f79815533 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -760,6 +760,9 @@ xfs_vm_swap_activate(
> {
> struct xfs_inode *ip = XFS_I(file_inode(swap_file));
>
> + if (xfs_is_zoned_inode(ip))
> + return -EINVAL;
> +
> /*
> * Swap file activation can race against concurrent shared extent
> * removal in files that have been cloned. If this happens,
Looks good to me.
Reviewed-by: Hans Holmberg <hans.holmberg@wdc.com>
next prev parent reply other threads:[~2025-08-18 13:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-18 5:06 zoned allocator fixes Christoph Hellwig
2025-08-18 5:06 ` [PATCH 1/3] xfs: remove xfs_last_used_zone Christoph Hellwig
2025-08-18 13:05 ` Hans Holmberg
2025-08-19 5:56 ` Damien Le Moal
2025-08-18 5:06 ` [PATCH 2/3] xfs: kick off inodegc when failing to reserve zoned blocks Christoph Hellwig
2025-08-18 13:05 ` Hans Holmberg
2025-08-18 5:06 ` [PATCH 3/3] xfs: reject swapon for inodes on a zoned file system earlier Christoph Hellwig
2025-08-18 13:06 ` Hans Holmberg [this message]
2025-08-19 7:17 ` Damien Le Moal
2025-08-19 13:11 ` zoned allocator fixes Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3edf33b-b2b5-4b8f-aa48-3b2b868a9e77@wdc.com \
--to=hans.holmberg@wdc.com \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).