From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sandeen.net ([63.231.237.45]:52800 "EHLO sandeen.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933935AbeCHAlw (ORCPT ); Wed, 7 Mar 2018 19:41:52 -0500 Subject: Re: [PATCH 1/2] xfs: always check for and process unlinked inodes on mount From: Eric Sandeen References: <83696ce6-4054-0e77-b4b8-e82a1a9fbbc3@redhat.com> Message-ID: Date: Wed, 7 Mar 2018 18:41:51 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Eric Sandeen , linux-xfs I suppose this should be titled "... on log processing" It happens during the log handling part of mount, but is outside of dirty log replay. On 3/7/18 5:32 PM, Eric Sandeen wrote: > Process any unlinked inodes unconditionally; this allows us to > skip dirtying the log on frozen filesystems and still have > proper recovery on the next mount. > > Signed-off-by: Eric Sandeen > --- > > diff --git a/fs/xfs/xfs_log_recover.c b/fs/xfs/xfs_log_recover.c > index 1937a93..2a645c0 100644 > --- a/fs/xfs/xfs_log_recover.c > +++ b/fs/xfs/xfs_log_recover.c > @@ -5854,8 +5854,6 @@ static inline bool xlog_item_is_intent(struct xfs_log_item *lip) > */ > xfs_log_force(log->l_mp, XFS_LOG_SYNC); > > - xlog_recover_process_iunlinks(log); > - > xlog_recover_check_summary(log); > > xfs_notice(log->l_mp, "Ending recovery (logdev: %s)", > @@ -5865,6 +5863,14 @@ static inline bool xlog_item_is_intent(struct xfs_log_item *lip) > } else { > xfs_info(log->l_mp, "Ending clean mount"); > } > + > + /* > + * Process any unlinked inodes unconditionally, this allows us to > + * skip dirtying the log on frozen filesystems and still have > + * proper recovery on the next mount. > + */ > + xlog_recover_process_iunlinks(log); > + > return 0; > } > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >