linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: linux-xfs <linux-xfs@vger.kernel.org>,
	"Darrick J. Wong" <darrick.wong@oracle.com>
Subject: [PATCH] xfs_repair: Fix uninit var in process_leaf_attr_level
Date: Wed, 25 Jan 2017 20:30:05 -0600	[thread overview]
Message-ID: <fe6cd162-4f2a-d470-f8ea-8a028a649212@redhat.com> (raw)

My unreviewed maintainer adjustment on the way in gets a
brown paper bag.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/repair/attr_repair.c b/repair/attr_repair.c
index 158e31a..9ec2231 100644
--- a/repair/attr_repair.c
+++ b/repair/attr_repair.c
@@ -753,6 +753,7 @@ process_leaf_attr_level(xfs_mount_t	*mp,
 	struct xfs_attr3_icleaf_hdr leafhdr;
 
 	da_bno = da_cursor->level[0].bno;
+	ino = da_cursor->ino;
 	/*
 	 * 0 is the root block and no block
 	 * pointer can point to the root block of the btree
@@ -764,7 +765,6 @@ process_leaf_attr_level(xfs_mount_t	*mp,
 		goto error_out;
 	}
 
-	ino = da_cursor->ino;
 	prev_bno = 0;
 
 	do {


             reply	other threads:[~2017-01-26  2:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-26  2:30 Eric Sandeen [this message]
2017-01-26  2:33 ` [PATCH] xfs_repair: Fix uninit var in process_leaf_attr_level Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe6cd162-4f2a-d470-f8ea-8a028a649212@redhat.com \
    --to=sandeen@redhat.com \
    --cc=darrick.wong@oracle.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).