* [PATCH] xfs_repair: Fix uninit var in process_leaf_attr_level
@ 2017-01-26 2:30 Eric Sandeen
2017-01-26 2:33 ` Darrick J. Wong
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2017-01-26 2:30 UTC (permalink / raw)
To: linux-xfs, Darrick J. Wong
My unreviewed maintainer adjustment on the way in gets a
brown paper bag.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/repair/attr_repair.c b/repair/attr_repair.c
index 158e31a..9ec2231 100644
--- a/repair/attr_repair.c
+++ b/repair/attr_repair.c
@@ -753,6 +753,7 @@ process_leaf_attr_level(xfs_mount_t *mp,
struct xfs_attr3_icleaf_hdr leafhdr;
da_bno = da_cursor->level[0].bno;
+ ino = da_cursor->ino;
/*
* 0 is the root block and no block
* pointer can point to the root block of the btree
@@ -764,7 +765,6 @@ process_leaf_attr_level(xfs_mount_t *mp,
goto error_out;
}
- ino = da_cursor->ino;
prev_bno = 0;
do {
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] xfs_repair: Fix uninit var in process_leaf_attr_level
2017-01-26 2:30 [PATCH] xfs_repair: Fix uninit var in process_leaf_attr_level Eric Sandeen
@ 2017-01-26 2:33 ` Darrick J. Wong
0 siblings, 0 replies; 2+ messages in thread
From: Darrick J. Wong @ 2017-01-26 2:33 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Wed, Jan 25, 2017 at 08:30:05PM -0600, Eric Sandeen wrote:
> My unreviewed maintainer adjustment on the way in gets a
> brown paper bag.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>
> diff --git a/repair/attr_repair.c b/repair/attr_repair.c
> index 158e31a..9ec2231 100644
> --- a/repair/attr_repair.c
> +++ b/repair/attr_repair.c
> @@ -753,6 +753,7 @@ process_leaf_attr_level(xfs_mount_t *mp,
> struct xfs_attr3_icleaf_hdr leafhdr;
>
> da_bno = da_cursor->level[0].bno;
> + ino = da_cursor->ino;
> /*
> * 0 is the root block and no block
> * pointer can point to the root block of the btree
> @@ -764,7 +765,6 @@ process_leaf_attr_level(xfs_mount_t *mp,
> goto error_out;
> }
>
> - ino = da_cursor->ino;
> prev_bno = 0;
>
> do {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-26 2:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-26 2:30 [PATCH] xfs_repair: Fix uninit var in process_leaf_attr_level Eric Sandeen
2017-01-26 2:33 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).