From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A880ECAA3C for ; Mon, 12 Jun 2023 17:30:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233445AbjFLRaL (ORCPT ); Mon, 12 Jun 2023 13:30:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237157AbjFLR33 (ORCPT ); Mon, 12 Jun 2023 13:29:29 -0400 Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED1D8129 for ; Mon, 12 Jun 2023 10:29:27 -0700 (PDT) Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-777a9ca9112so45574739f.1 for ; Mon, 12 Jun 2023 10:29:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1686590967; x=1689182967; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TFWZn0n6OGSV4kVBbYftRZo2ty8H3Bci18vHV3tC0Uw=; b=G8JD84g8f9Aeee5HTb3j/7SgOJh5Qn/aixcR5+GacNDkyxtuggQHLsYFnC6bEXjPzX CFDBvYGcEzc1Ttl+IUa85nXJaOctQM+3Wy8xIs72fL9U/EZpbxXE0eJqLOsg7VKrMIC5 weokx/JiqIENqjn+LXa6+yAoNSa4c/vJ0Jsnyuao7rqrJ9O5YfZGoHB+GpSAFFK7rf5t e3cgg3kcuwmy9bn41z6Fh0yOgs9hNIUGeYIWRQdX3YWh0zxo6BeyQp86i/LzYL50hqt3 RK/B1dfYGtQYx6zG0W9kb866p34EKPfBVuRjPGLhqy6GqZBIlr+JvIP15dv+x4wcQyQ9 QDCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686590967; x=1689182967; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TFWZn0n6OGSV4kVBbYftRZo2ty8H3Bci18vHV3tC0Uw=; b=Hj5a8GQl74qWWc2pgQVeqQ4xgFTtc9bfeT3P5p6pIR9Sdx+/OeDDc7kJHpiJ9OnoHF 3wzwkp30xkeB10lKj2N5nDcJD0+AWHbUtAQcquB2nvQzY0gFk9BDFmOUr4CUd7/L0zy9 kGNRhmbxdF89z7jfnbOCqquxQqDDrYiB9jS/kuopC7vfzjmXhWkk81kTPv4+jl2gwAuz PL+yIouptnLiu0z+lr2Uwp7hT12ZcrA/gfXRTQbZA2xNlx1rAPqMXAJH4JYvP+rS6EoK a+OERBrGnEX60Ur/FVmrZ7Is91bgz+v9Se6pbFSwgt7jiFSBehkHyb7pR+FH2nTKwI3o 1NBg== X-Gm-Message-State: AC+VfDwMwVtKeCBxPvQsZU8UmtXNg5wgLOFChrKyd55sZBepCcXlCIuB OjxX1UHev8L34RW8ANUKWHhgtQ== X-Google-Smtp-Source: ACHHUZ5bDIcReS9+YhyEZIK2CCIqFlbV7Kvzlpd9NEY+7ScY3yUVxP60SWtqVvazxqpp+hgdcN0Nww== X-Received: by 2002:a92:440e:0:b0:33b:e24b:ca46 with SMTP id r14-20020a92440e000000b0033be24bca46mr5234504ila.3.1686590967286; Mon, 12 Jun 2023 10:29:27 -0700 (PDT) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id t11-20020a92d14b000000b0033d2d6620b0sm3295648ilg.2.2023.06.12.10.29.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jun 2023 10:29:26 -0700 (PDT) Message-ID: Date: Mon, 12 Jun 2023 11:29:25 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [6.5-rc5 regression] core dump hangs (was Re: [Bug report] fstests generic/051 (on xfs) hang on latest linux v6.5-rc5+) Content-Language: en-US To: Linus Torvalds Cc: "Darrick J. Wong" , Dave Chinner , Zorro Lang , linux-xfs@vger.kernel.org, "Eric W. Biederman" , Mike Christie , "Michael S. Tsirkin" , linux-kernel@vger.kernel.org References: <20230611124836.whfktwaumnefm5z5@zlang-mailbox> <20230612015145.GA11441@frogsfrogsfrogs> <20230612153629.GA11427@frogsfrogsfrogs> <13d9e4f2-17c5-0709-0cc0-6f92bfe9f30d@kernel.dk> <212a190c-f81e-2876-cf14-6d1e37d47192@kernel.dk> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On 6/12/23 10:57 AM, Linus Torvalds wrote: > On Mon, Jun 12, 2023 at 9:45 AM Jens Axboe wrote: >> >> You snipped the suspicion in my reply on why that exists, to avoid >> io_wq_worker_sleeping() triggering. > > I'm not seeing why triggering io_wq_worker_sleeping() should even be a > problem in the first place. > > I suspect that is entirely historical too, and has to do with how it > used to do that > > struct io_worker *worker = kthread_data(tsk); > struct io_wqe *wqe = worker->wqe; > > back in the bad old days of kthreads. > > But yeah, I don't know that code. Looks fine to me to just kill it indeed, whatever we did need this for is definitely no longer the case. I _think_ we used to have something in the worker exit that would potentially sleep which is why we killed it before doing that, now it just looks like dead code. -- Jens Axboe