Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

[Darrick J. Wong]

On Fri, Oct 27, 2023 at 06:19:33PM +0200, Anthony Iliopoulos wrote:
> On Fri, Oct 27, 2023 at 08:45:05AM -0700, Darrick J. Wong wrote:
> > 
> > mkfs.xfs in xfsprogs 6.5 turned on both the large extent counts and
> > reverse mapping btree features by default.  My guess is that grub hasn't
> > caught up with those changes to the ondisk format yet.
> > 
> > Ah, yeah, upstream grub hasn't picked up large extent counts (internally
> > called nrext64) yet.
> > https://git.savannah.gnu.org/cgit/grub.git/tree/grub-core/fs/xfs.c#n83
> 
> Yeap it is due to nrext64, I've submitted a patch to grub (should have
> cc'ed linux-xfs..)
> 
> https://lore.kernel.org/grub-devel/20231026095339.31802-1-ailiop@suse.com/

FWIW the patch turning on nrext64 by default was intended for xfsprogs
6.6, but the maintainer decided to merge it early.  No complaints here,
but that was a little sooner than I had intended.

--D

> Regards,
> Anthony

Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

[Philip Hands]

"Darrick J. Wong" <djwong@kernel.org> writes:
...
> Curiously, this log says:
>
> Oct 24 05:35:32 in-target: Setting up xfsprogs (6.4.0-1) ...^M
>
> So ... is it running 6.4 and not 6.5?

The daily test versions of Debian-Installer draw components from
"unstable", which is where the 6.5 version is at present, which then
creates the file system with problematic flags.

However, the test images normally install "testing" onto the target, to
avoid pointless breakage caused by the potential for "unstable" to be,
well ... unstable, hence the 6.4 version that gets put in-target.

Having 6.4 in the target system doesn't help in this case, because the
damage has already been done while creating the file system, by the 6.5
version of the udeb.

One can confirm that this is the case by looking for xfsprogs in here:

  https://openqa.debian.net/tests/198911/logfile?filename=complete_install-DI-installed-pkgs.txt

which lists the installed components (udebs) of the installer that's running:

  xfsprogs-udeb                            6.5.0-1

Cheers, Phil.
-- 
Philip Hands -- https://hands.com/~phil

Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

[Philip Hands]

Anthony Iliopoulos <ailiop@suse.com> writes:
...
> Yeap it is due to nrext64, I've submitted a patch to grub (should have
> cc'ed linux-xfs..)
>
> https://lore.kernel.org/grub-devel/20231026095339.31802-1-ailiop@suse.com/

That certainly seems to fix this bug.

I tested it by applying that patch to grub, and then getting that
version of grub installed into the target just after the initial attempt
to run grub had failed, which then allows a retry of the grub install
step to succeed.

Also, with the patched version: `grub-probe -d /dev/vda1` produces 'xfs'

Cheers, Phil.
-- 
Philip Hands -- https://hands.com/~phil

Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

[Bastian Germann]

Control: reassign -1 grub2

Please consider applying the identified patch so that debian installer does not break installing on XFS.

Processed: Re: Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

[Debian Bug Tracking System]

Processing control commands:

> reassign -1 grub2
Bug #1054644 [xfsprogs-udeb] xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices
Bug reassigned from package 'xfsprogs-udeb' to 'grub2'.
No longer marked as found in versions xfsprogs/6.5.0-1.
Ignoring request to alter fixed versions of bug #1054644 to the same values previously set

-- 
1054644: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1054644
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

Processed: Re: Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

[Debian Bug Tracking System]

Processing control commands:

> clone -1 -2
Bug #1054644 [grub2] xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices
Bug 1054644 cloned as bug 1059424
> reassign -2 xfsprogs
Bug #1059424 [grub2] xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices
Bug reassigned from package 'grub2' to 'xfsprogs'.
Ignoring request to alter found versions of bug #1059424 to the same values previously set
Ignoring request to alter fixed versions of bug #1059424 to the same values previously set

-- 
1054644: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1054644
1059424: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1059424
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems

Processed: Re: Bug#1054644: xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices

[Debian Bug Tracking System]

Processing control commands:

> tag 1059424 patch
Bug #1059424 [xfsprogs] xfsprogs-udeb: causes D-I to fail, reporting errors about missing partition devices
Added tag(s) patch.

-- 
1059424: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1059424
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems