public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Nathan Scott <nathans@debian.org>
To: linux-xfs@oss.sgi.com
Subject: Re: [PATCH 0/4] Refactor release scripts to conform to using git	archive
Date: Wed, 6 Feb 2013 06:28:10 +0000 (UTC)	[thread overview]
Message-ID: <loom.20130206T072310-821@post.gmane.org> (raw)
In-Reply-To: 20130206011547.GT2667@dastard

Dave Chinner <david <at> fromorbit.com> writes:

> 
> It breaks the 'make deb' command for all the trees.
> 

(thanks for checking!)

> The debian package build creates a link tree so that it builds
> outside the main source tree (e.g. in ./xfsprogs-3.1.10) and as part
> of the build it runs 'make dist' to build a tarball from that link
> tree. That now fails with:
> 
> fatal: current working directory is untracked
> 
> coming from the git archive command that is now used to build the
> tarball.
> 
> Nathan, can the debian package build use git-archive? I'm under the
> impression that you have to be able to build debian packages from a
> source tarball or a source package, and so the build can't rely on
> being inside a VCS controlled tree. That rules out using git archive
> for tarball creation...
> 

IIRC, the requirement is to be building in a tree that had a basename
of for <package>-<version> - hence the link'd tree build previously.
If that can be maintained somehow, the build should be fine.  Symlinks
did not work very well (IIRC) - the build tools might've used basename
or realpath or something like that, but I do remember trying that.

> Also, given that the previous tarball creation used the same link
> tree build as the debian package build (i.e. make source-link), that
> implies the debian pacakges are going to be missing files using this
> technique. Doesn't that mean we have to fix the file list being fed
> into the source-link target regardless of whether we use git archive
> to build the tarball?

The source tarball definitely needs to have the package-version prefix
for all the files it contains - has a mechanism to acheive that been
found?

cheers.

--
Nathan

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-02-06  6:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <50F44B2E.9050408@sgi.com>
     [not found] ` <50F44B62.7060504@sgi.com>
2013-02-01  2:10   ` [PATCH 1/4] xfsprogs: Refactor release scripts to conform to using git archive Ben Myers
     [not found] ` <50F44B87.3040102@sgi.com>
2013-02-01  2:36   ` [PATCH 2/4] xfsdump: " Ben Myers
     [not found] ` <50F44BA5.9030509@sgi.com>
2013-02-01  2:55   ` [PATCH 3/4] xfstests: " Ben Myers
     [not found] ` <50F44BC0.80708@sgi.com>
2013-02-01 16:47   ` [PATCH 4/4] dmapi: " Ben Myers
2013-02-01 19:09 ` [PATCH 0/4] " Ben Myers
2013-02-06  1:15   ` Dave Chinner
2013-02-06  6:28     ` Nathan Scott [this message]
2013-02-06 19:31       ` [PATCH 0/4] Refactor release scripts to conform to using git?archive Ben Myers
2013-02-06 22:47       ` Dave Chinner
2013-02-14  1:08     ` [PATCH 0/4] Refactor release scripts to conform to using git archive Ben Myers
2013-02-14  2:14       ` Nathan Scott
2013-02-14 16:24         ` Ben Myers
2013-02-14 16:54           ` xfsprogs: update 'make deb' to use tarball Ben Myers
2013-02-14 22:26             ` Nathan Scott
2013-02-14 22:50             ` Dave Chinner
2013-02-14 17:31           ` xfsdump: update 'make deb' to use tarball archive Ben Myers
2013-02-14 22:27             ` Nathan Scott
2013-02-14 22:51             ` Dave Chinner
2013-02-14 22:25           ` [PATCH 0/4] Refactor release scripts to conform to using git archive Nathan Scott
2013-02-14 22:37             ` Ben Myers
2013-02-14 22:36           ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20130206T072310-821@post.gmane.org \
    --to=nathans@debian.org \
    --cc=linux-xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox