From: Niv Sardi <xaiki@cxhome.ath.cx>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] split xfs_ioc_xattr
Date: Wed, 16 Apr 2008 13:47:13 +1000 [thread overview]
Message-ID: <ncclk3ejwam.fsf@sgi.com> (raw)
In-Reply-To: <20080414032940.GA10579@lst.de> (Christoph Hellwig's message of "Mon, 14 Apr 2008 05:29:40 +0200")
Christoph Hellwig <hch@lst.de> writes:
> On Mon, Apr 14, 2008 at 01:14:47PM +1000, Niv Sardi wrote:
>>
>>
>> Christoph Hellwig <hch@lst.de> writes:
>> > The three subcases of xfs_ioc_xattr don't share any semantics and almost
>> > no code, so split it into three separate helpers.
>> >
>> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>>
>> Looks good to me, aren't the likely() unlinkely() deprecated ? shouldn't
>> they be killed ?
>
> Why would they be deprecated?
just an impression I had from on of Dave's comment to one of my patches:
« Can we kill all the likely() crap out of here? Modern hardware
branch predictors are far better than static prediction hints. »
But it looks like a matter of taste…
I'll push it in.
--
Niv Sardi
next prev parent reply other threads:[~2008-04-16 3:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 20:40 [PATCH] split xfs_ioc_xattr Christoph Hellwig
2008-04-14 3:14 ` Niv Sardi
2008-04-14 3:29 ` Christoph Hellwig
2008-04-16 3:47 ` Niv Sardi [this message]
2008-04-16 6:37 ` David Chinner
2008-04-16 7:06 ` Timothy Shimmin
2008-04-16 7:29 ` Andi Kleen
2008-04-18 7:06 ` likely and unlikely was: " Timothy Shimmin
2008-04-18 13:34 ` Andi Kleen
2008-04-18 14:05 ` Eric Sandeen
2008-04-21 0:33 ` David Chinner
2008-04-21 7:55 ` Andi Kleen
2008-04-21 21:41 ` David Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ncclk3ejwam.fsf@sgi.com \
--to=xaiki@cxhome.ath.cx \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox