From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2130.oracle.com ([156.151.31.86]:32868 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728848AbfC2OrJ (ORCPT ); Fri, 29 Mar 2019 10:47:09 -0400 Subject: Re: [PATCH v3 2/3] block: verify data when endio From: "Martin K. Petersen" References: <20190329142346.1677-1-bob.liu@oracle.com> <20190329142346.1677-3-bob.liu@oracle.com> <41c8688a-65bd-96ac-9b23-4facd0ade4a7@kernel.dk> Date: Fri, 29 Mar 2019 10:46:53 -0400 In-Reply-To: (Jens Axboe's message of "Fri, 29 Mar 2019 08:38:04 -0600") Message-ID: MIME-Version: 1.0 Content-Type: text/plain Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Jens Axboe Cc: "Martin K. Petersen" , Bob Liu , linux-block@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, shirley.ma@oracle.com, allison.henderson@oracle.com, david@fromorbit.com, darrick.wong@oracle.com, hch@infradead.org, adilger@dilger.ca, tytso@mit.edu Jens, > I didn't miss that, but it fixes nothing. That will unify the 40 bytes > with 8 bytes, we're still growing the bio by a LOT. And we can't even > nicely hide this behind some ifdef, sine distros enable everything and > hence we're solving nothing by doing that. We'll just need to handle it exactly like the integrity stuff. We only allocate the extra bits when the underlying device indicates that it's required and desired. -- Martin K. Petersen Oracle Linux Engineering