Re: [PATCH v2 01/16] block: Add atomic write operations to request_queue limits

Martin K. Petersen
2023-12-14T04:35:10Z

Hi Ming!

>> + lim->atomic_write_unit_min_sectors = 0;
>> + lim->atomic_write_unit_max_sectors = 0;
>> + lim->atomic_write_max_sectors = 0;
>> + lim->atomic_write_boundary_sectors = 0;
>
> Can we move the four into single structure and setup them in single
> API? Then cross-validation can be done in this API.

Why would we put them in a separate struct? We don't do that for any of
the other queue_limits.

--
Martin K. Petersen Oracle Linux Engineering