From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33CE7C433DF for ; Thu, 11 Jun 2020 22:40:32 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9B746206D7 for ; Thu, 11 Jun 2020 22:40:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KDmaFm8v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9B746206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 49jf2P3bVqzDqtK for ; Fri, 12 Jun 2020 08:40:29 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--ndesaulniers.bounces.google.com (client-ip=2607:f8b0:4864:20::b49; helo=mail-yb1-xb49.google.com; envelope-from=3cllixgwkdf0i89n5pgid9mnbjjbg9.7jhgdipskk7-89qgdnon.jug56n.jmb@flex--ndesaulniers.bounces.google.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20161025 header.b=KDmaFm8v; dkim-atps=neutral Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 49jf0S6Z4mzDqrm for ; Fri, 12 Jun 2020 08:38:44 +1000 (AEST) Received: by mail-yb1-xb49.google.com with SMTP id y3so8355263ybf.4 for ; Thu, 11 Jun 2020 15:38:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:message-id:date:subject:from:to; bh=vH1Jdl9UovulKp0PaaP+MmxVuSnD40skakQX91jUExE=; b=KDmaFm8vzCYT3oKJnfCXZq3hPMg+faO19e1YoSYNlIHIs0esE/+dqXfaTifXdemE9k KfEgE7d3yEidopuhWYozLHpqzOizTKa1yLAuvNmGlcgkArMpOkmQnrDD1Yh69iSLqdra JXf2ByohY57OdyYbHcvGLM7nOAG3jk1VOd4sejlGvSpGbzCXunaq/ZtaAqT8NsfzoZED 3BcHVr3Np069USL5mYahnaNkgl1Za/wgaSC3iGYYD92VTwFMnYU10aeyPb/qjByW+aKs HU+jkn41kb+Q07j8pPxB0QiuGRG0umFJYERp4iZwEeDiQqJv4pJyjGMHe6lwKbsBQ5pZ qB6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:message-id:date:subject:from:to; bh=vH1Jdl9UovulKp0PaaP+MmxVuSnD40skakQX91jUExE=; b=nGJJ8lqaHDdkyOWO+1otzFzR69MnX3AfGwieYZ7GJ/LD6g4FCej3gFjpBL2meN1Cy3 wAzQj4J5KE2BlCHSQo0N6duMS6ao7RTjVURO4xxlZrRv/XtEJZpn5wfvDi/QgGwrRdxf rysUuAmkNMUsl66SRoiEXZUVtJ7sOSZ1T8wz+4eL8VJ6oFL72Ycs92DzKGiBZPbrHDBe rgWY26EX4Kd8R9Yt+8SJcS26MhqBegTKNjh9gQkE7hDMKhfQzqkVOeSR/YY1YYCkVlY2 qz+myeJmjRhymzHOkRkhsDslxR1/ElzHfrEcdaf0Gen/I89yvYbJF1JQDNk858LxGwUF TCUA== X-Gm-Message-State: AOAM531K8IKQZNV8gHfWIXH+D9Sclj3Amo2+aJrSkCgHnpoQ8bW2sHJz DdhJVaC55f2gV/iPM5Y8bdr6eaJx5gLyZGQyK1k= X-Google-Smtp-Source: ABdhPJyGVqLpmgZRZWU1edJu5iII4R7xxKzufvO+ZIrC8263xKyKyVQ90aQe9dJ4fcLE+PoPNsWq0TD8mfL77U0sFB4= MIME-Version: 1.0 X-Received: by 2002:a25:d110:: with SMTP id i16mr15548576ybg.155.1591915120701; Thu, 11 Jun 2020 15:38:40 -0700 (PDT) Message-ID: <00000000000048bfef05a7d69f21@google.com> Date: Thu, 11 Jun 2020 22:38:40 +0000 Subject: From: To: patch-notifications@ellerman.id.au, christophe.leroy@c-s.fr, segher@kernel.crashing.org, benh@kernel.crashing.org, paulus@samba.org, npiggin@gmail.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Date: Thu, 11 Jun 2020 15:38:38 -0700 From: Nick Desaulniers To: Michael Ellerman , christophe.leroy@c-s.fr, segher@kernel.crashing.org Cc: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , npiggin@gmail.com, segher@kernel.crashing.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com Subject: Re: [PATCH v4 1/2] powerpc/uaccess: Implement unsafe_put_user() using 'asm goto' Message-ID: <20200611223838.GA60089@google.com> References: <23e680624680a9a5405f4b88740d2596d4b17c26.1587143308.git.christophe.leroy@c-s.fr> <49YBKY13Szz9sT4@ozlabs.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49YBKY13Szz9sT4@ozlabs.org> On Fri, May 29, 2020 at 02:24:16PM +1000, Michael Ellerman wrote: > On Fri, 2020-04-17 at 17:08:51 UTC, Christophe Leroy wrote: > > unsafe_put_user() is designed to take benefit of 'asm goto'. > > > > Instead of using the standard __put_user() approach and branch > > based on the returned error, use 'asm goto' and make the > > exception code branch directly to the error label. There is > > no code anymore in the fixup section. > > > > This change significantly simplifies functions using > > unsafe_put_user() > ... > > > > Signed-off-by: Christophe Leroy > > Reviewed-by: Segher Boessenkool > Applied to powerpc topic/uaccess-ppc, thanks. > https://git.kernel.org/powerpc/c/334710b1496af8a0960e70121f850e209c20958f > cheers Hello! It seems this patch broke our ppc32 builds, and we had to disable them [0]. :( From what I can tell, though Michael mentioned this was merged on May 29, but our CI of -next was green for ppc32 until June 4, then mainline went red June 6. So this patch only got 2 days of soak time before the merge window opened. A general issue with the -next workflow seems to be that patches get different amounts of soak time. For higher risk patches like this one, can I please ask that they be help back a release if close to the merge window? Segher, Cristophe, I suspect Clang is missing support for the %L and %U output templates [1]. I've implemented support for some of these before in Clang via the documentation at [2], but these seem to be machine specific? Can you please point me to documentation/unit tests/source for these so that I can figure out what they should be doing, and look into implementing them in Clang? (Apologies for the tone off this email; I had typed up a nice fuller report with links, but it seemed that mutt wrote out an empty postponed file, and I kind of just want to put my laptop in the garbage right now. I suspect our internal SMTP tool will also mess up some headers, but lets see (Also, too lazy+angry right now to solve).) [0] https://github.com/ClangBuiltLinux/continuous-integration/pull/279 [1] https://bugs.llvm.org/show_bug.cgi?id=46186 [2] https://gcc.gnu.org/onlinedocs/gccint/Output-Template.html#Output-Template