From: "Alfred Manheim" <alfman@austin.rr.com>
To: "'Liu Dave-r63238'" <DaveLiu@freescale.com>,
"'Phillips Kim-R1AAHA'" <Kim.Phillips@freescale.com>,
"'Keith Mund'" <keith.mund@clearcube.com>
Cc: linuxppc-dev@ozlabs.org, u-boot-users@lists.sourceforge.net
Subject: RE: [U-Boot-Users] MPC83xx - previous patch to set MBAR
Date: Wed, 1 Aug 2007 21:34:57 -0500 [thread overview]
Message-ID: <000001c7d4ad$b83a07b0$28ae1710$@rr.com> (raw)
In-Reply-To: <995B09A8299C2C44B59866F6391D2635AAD0C5@zch01exm21.fsl.freescale.net>
This was to the wrong group.
Thanks for the responses and the clarification. The "needed for CodeWarrior
only" part is what I suspected.
Keith Mund
-----Original Message-----
From: linuxppc-dev-bounces+alfman=austin.rr.com@ozlabs.org
[mailto:linuxppc-dev-bounces+alfman=austin.rr.com@ozlabs.org] On Behalf Of
Liu Dave-r63238
Sent: Wednesday, August 01, 2007 9:15 PM
To: Phillips Kim-R1AAHA; Keith Mund
Cc: linuxppc-dev@ozlabs.org; u-boot-users@lists.sourceforge.net
Subject: RE: [U-Boot-Users] MPC83xx - previous patch to set MBAR
> > The end result simply adds a line to set MBAR to match IMMRBAR.
> >
> > lis r3, CFG_IMMRBAR@h
> > ori r3, r3, CFG_IMMRBAR@l
> > stw r3, IMMRBAR(r4)
> > + mtspr MBAR, r3
> >
> > Are these patches routinely added to the mainstream u-boot code?
> >
> > Is there any reason why this fix is not a good idea?
> >
> does setting MBAR really fix anything?
>
> MBAR doesn't live up to its name. It's a general-purpose scratch
> register - the hardware doesn't do anything with it. So, wrt
Kim is right.
MBAR setting is added by two years ago, it is not really fix anything.
I set the MBAR to be easier to use the CodeWarriror. The CodeWarrior must
set the MBAR first, then it will be able to access the IMMR.
Dave
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
next prev parent reply other threads:[~2007-08-02 2:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-01 13:30 [2.6 patch] ppc .gitignore update Adrian Bunk
2007-08-01 13:53 ` Grant Likely
2007-08-01 19:06 ` Adrian Bunk
2007-08-01 20:20 ` MPC83xx - previous patch to set MBAR Keith Mund
2007-08-02 0:20 ` Kim Phillips
2007-08-02 2:14 ` [U-Boot-Users] " Liu Dave-r63238
2007-08-02 2:34 ` Alfred Manheim [this message]
2007-08-02 15:28 ` Scott Wood
2007-08-02 16:12 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001c7d4ad$b83a07b0$28ae1710$@rr.com' \
--to=alfman@austin.rr.com \
--cc=DaveLiu@freescale.com \
--cc=Kim.Phillips@freescale.com \
--cc=keith.mund@clearcube.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=u-boot-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).