From: "Joakim Tjernlund" <joakim.tjernlund@transmode.se>
To: "'Kim Phillips'" <kim.phillips@freescale.com>, <netdev@vger.kernel.org>
Cc: linuxppc-dev@ozlabs.org, jgarzik@pobox.com
Subject: RE: [PATCH] changes to ucc_geth driver as a result of qe_lib changesand bugfixes
Date: Sat, 7 Oct 2006 12:23:45 +0200 [thread overview]
Message-ID: <000101c6e9fa$abc94cf0$020120ac@Jocke> (raw)
In-Reply-To: <20061006172229.10b144df.kim.phillips@freescale.com>
>
> changes due to qe_lib changes include:
>
> o removed platform_device code, replaced with of_device
> o removed typedefs
> o uint -> u32 conversions
> o removed following defines:
> QE_SIZEOF_BD, BD_BUFFER_ARG, BD_BUFFER_CLEAR, BD_BUFFER,
> BD_STATUS_AND_LENGTH_SET, BD_STATUS_AND_LENGTH, and BD_BUFFER_SET
> because they hid sizeof/in_be32/out_be32 operations from the reader.
> o removed irrelevant comments, added others to resemble
> removed BD_ defines
> o const'd and uncasted all get_property() assignments
>
> bugfixes, courtesy of Scott Wood, include:
>
> - Read phy_address as a u32, not u8.
> - Match on type == "network" as well as compatible == "ucc_geth", as
> device_is_compatible() will only compare up to the length of the
> test string, allowing "ucc_geth_phy" to match as well.
> - fixes the MAC setting code in ucc_geth.c. The old code was
> overwriting and dereferencing random stack contents.
>
> Signed-off-by: Li Yang <leoli@freescale.com>
> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
>
> ---
>
> Jeff, this patch fixes ucc_geth buildtime and runtime errors;
> please apply.
Can you send the complete patch againt paulus tree to get ucc_qeth driver going? Currently there
are too many patches floating around.
Regards
Joakim
prev parent reply other threads:[~2006-10-07 10:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 22:22 [PATCH] changes to ucc_geth driver as a result of qe_lib changes and bugfixes Kim Phillips
2006-10-07 10:23 ` Joakim Tjernlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000101c6e9fa$abc94cf0$020120ac@Jocke' \
--to=joakim.tjernlund@transmode.se \
--cc=jgarzik@pobox.com \
--cc=kim.phillips@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).