From: "Joakim Tjernlund" <joakim.tjernlund@lumentis.se>
To: "'Tom Rini'" <trini@kernel.crashing.org>
Cc: <linuxppc-embedded@lists.linuxppc.org>
Subject: RE: tx_full v.s tx_free race fix in 8xx_io/enet.c?
Date: Wed, 3 Dec 2003 18:08:17 +0100 [thread overview]
Message-ID: <002501c3b9c0$0c759e00$0a01a8c0@LUMENTIS02> (raw)
In-Reply-To: <20031203161513.GG912@stop.crashing.org>
> On Tue, Dec 02, 2003 at 12:00:27AM +0100, Joakim Tjernlund wrote:
>
> > It seems to me that the old tx_full stuff is working better that the
> > new tx_free.
>
> What problem are you seeing without making any changes to the
> code as it
> stands?
I have impl. the NAPI method in enet.c and had removed the spin_lock_irq()
in the xmit procedure since I don't belive I need these any more and all was well.
Then I discoverd I had forgotten to apply the tx_free change so I added it and
then I got an oops. Restoring the spin_lock_irq() makes the behaviour identical.
Thats why I wonder what race they are supposed to fix since the only difference
I get is the above oops on a mpc862.
Something I find a bit odd is that I can run ping -s 1472 -f <myTargetIp>
without problems, but if i "jump start" the ping with "ping -s 800 -f <myTargetIp> -l 8"
I start to loose packages. Ifconfig shows no errors for both cases.
Do you get the same?
Jocke
** Sent via the linuxppc-embedded mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2003-12-03 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-01 23:00 tx_full v.s tx_free race fix in 8xx_io/enet.c? Joakim Tjernlund
2003-12-03 16:15 ` Tom Rini
2003-12-03 17:08 ` Joakim Tjernlund [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-12-04 14:32 Joakim Tjernlund
2003-12-05 19:53 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002501c3b9c0$0c759e00$0a01a8c0@LUMENTIS02' \
--to=joakim.tjernlund@lumentis.se \
--cc=linuxppc-embedded@lists.linuxppc.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).