From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Alexandre Ghiti <alex@ghiti.fr>,
linux@armlinux.org.uk, catalin.marinas@arm.com,
will.deacon@arm.com, tony.luck@intel.com, fenghua.yu@intel.com,
ralf@linux-mips.org, paul.burton@mips.com, jhogan@kernel.org,
jejb@parisc-linux.org, deller@gmx.de, benh@kernel.crashing.org,
paulus@samba.org, mpe@ellerman.id.au, ysato@users.sourceforge.jp,
dalias@libc.org, davem@davemloft.net, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, x86@kernel.org, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-mips@linux-mips.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-arch@vger.kernel.org
Subject: Re: [PATCH v3 02/11] hugetlb: Introduce generic version of hugetlb_free_pgd_range
Date: Thu, 5 Jul 2018 10:22:30 +0000 [thread overview]
Message-ID: <005bf713-fb51-bf29-5f86-6f244cd49f35@c-s.fr> (raw)
In-Reply-To: <20180705051640.790-3-alex@ghiti.fr>
On 07/05/2018 05:16 AM, Alexandre Ghiti wrote:
> arm, arm64, mips, parisc, sh, x86 architectures use the
> same version of hugetlb_free_pgd_range, so move this generic
> implementation into asm-generic/hugetlb.h.
>
> Signed-off-by: Alexandre Ghiti <alex@ghiti.fr>
Build failure on mpc885_ads_defconfig
CC arch/powerpc/kernel/setup-common.o
In file included from arch/powerpc/kernel/setup-common.c:37:
./include/linux/hugetlb.h:191:65: error: expected identifier or '('
before '{' token
#define hugetlb_free_pgd_range(tlb, addr, end, floor, ceiling)
({BUG(); 0; })
^
./include/asm-generic/hugetlb.h:44:20: note: in expansion of macro
'hugetlb_free_pgd_range'
static inline void hugetlb_free_pgd_range(struct mmu_gather *tlb,
^~~~~~~~~~~~~~~~~~~~~~
see below
> ---
> arch/arm/include/asm/hugetlb.h | 12 ++----------
> arch/arm64/include/asm/hugetlb.h | 10 ----------
> arch/ia64/include/asm/hugetlb.h | 5 +++--
> arch/mips/include/asm/hugetlb.h | 13 ++-----------
> arch/parisc/include/asm/hugetlb.h | 12 ++----------
> arch/powerpc/include/asm/hugetlb.h | 4 +++-
> arch/sh/include/asm/hugetlb.h | 12 ++----------
> arch/sparc/include/asm/hugetlb.h | 4 +++-
> arch/x86/include/asm/hugetlb.h | 11 ++---------
> include/asm-generic/hugetlb.h | 11 +++++++++++
> 10 files changed, 30 insertions(+), 64 deletions(-)
>
[snip]
> diff --git a/arch/powerpc/include/asm/hugetlb.h b/arch/powerpc/include/asm/hugetlb.h
> index 3225eb6402cc..de46ee16b615 100644
> --- a/arch/powerpc/include/asm/hugetlb.h
> +++ b/arch/powerpc/include/asm/hugetlb.h
> @@ -4,7 +4,6 @@
>
> #ifdef CONFIG_HUGETLB_PAGE
> #include <asm/page.h>
> -#include <asm-generic/hugetlb.h>
>
> extern struct kmem_cache *hugepte_cache;
>
> @@ -113,6 +112,7 @@ static inline void flush_hugetlb_page(struct vm_area_struct *vma,
> void flush_hugetlb_page(struct vm_area_struct *vma, unsigned long vmaddr);
> #endif
>
> +#define __HAVE_ARCH_HUGETLB_FREE_PGD_RANGE
> void hugetlb_free_pgd_range(struct mmu_gather *tlb, unsigned long addr,
> unsigned long end, unsigned long floor,
> unsigned long ceiling);
> @@ -193,4 +193,6 @@ static inline pte_t *hugepte_offset(hugepd_t hpd, unsigned long addr,
> }
> #endif /* CONFIG_HUGETLB_PAGE */
>
> +#include <asm-generic/hugetlb.h>
> +
That include was previously inside #ifdef CONFIG_HUGETLB_PAGE.
Why put it outside ?
Christophe
next prev parent reply other threads:[~2018-07-05 10:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 5:16 [PATCH v3 00/11] hugetlb: Factorize hugetlb architecture primitives Alexandre Ghiti
2018-07-05 5:16 ` [PATCH v3 01/11] hugetlb: Harmonize hugetlb.h arch specific defines with pgtable.h Alexandre Ghiti
2018-07-05 5:16 ` [PATCH v3 02/11] hugetlb: Introduce generic version of hugetlb_free_pgd_range Alexandre Ghiti
2018-07-05 8:29 ` kbuild test robot
2018-07-05 10:22 ` Christophe Leroy [this message]
2018-07-05 10:48 ` Alex Ghiti
2018-07-05 5:16 ` [PATCH v3 03/11] hugetlb: Introduce generic version of set_huge_pte_at Alexandre Ghiti
2018-07-05 5:16 ` [PATCH v3 04/11] hugetlb: Introduce generic version of huge_ptep_get_and_clear Alexandre Ghiti
2018-07-05 5:16 ` [PATCH v3 05/11] hugetlb: Introduce generic version of huge_ptep_clear_flush Alexandre Ghiti
2018-07-05 5:16 ` [PATCH v3 06/11] hugetlb: Introduce generic version of huge_pte_none Alexandre Ghiti
2018-07-05 5:16 ` [PATCH v3 07/11] hugetlb: Introduce generic version of huge_pte_wrprotect Alexandre Ghiti
2018-07-05 5:16 ` [PATCH v3 08/11] hugetlb: Introduce generic version of prepare_hugepage_range Alexandre Ghiti
2018-07-05 9:39 ` kbuild test robot
2018-07-05 5:16 ` [PATCH v3 09/11] hugetlb: Introduce generic version of huge_ptep_set_wrprotect Alexandre Ghiti
2018-07-05 5:16 ` [PATCH v3 10/11] hugetlb: Introduce generic version of huge_ptep_set_access_flags Alexandre Ghiti
2018-07-05 5:16 ` [PATCH v3 11/11] hugetlb: Introduce generic version of huge_ptep_get Alexandre Ghiti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=005bf713-fb51-bf29-5f86-6f244cd49f35@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=alex@ghiti.fr \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=catalin.marinas@arm.com \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=jejb@parisc-linux.org \
--cc=jhogan@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paul.burton@mips.com \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox