[PATCH 2/4] powerpc: Add the ds1374 RTC to the mpc8349emds device tree.

[PATCH 2/4] powerpc: Add the ds1374 RTC to the mpc8349emds device tree.

[Scott Wood]

Signed-off-by: Scott Wood <scottwood@freescale.com>
---
 arch/powerpc/boot/dts/mpc8349emds.dts |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/boot/dts/mpc8349emds.dts b/arch/powerpc/boot/dts/mpc8349emds.dts
index 50f4886..889a5b8 100644
--- a/arch/powerpc/boot/dts/mpc8349emds.dts
+++ b/arch/powerpc/boot/dts/mpc8349emds.dts
@@ -55,12 +55,22 @@
 		};
 
 		i2c@3000 {
+			#address-cells = <1>;
+			#size-cells = <0>;
 			device_type = "i2c";
 			compatible = "fsl-i2c";
 			reg = <3000 100>;
 			interrupts = <e 8>;
 			interrupt-parent = <700>;
 			dfsrr;
+
+			rtc@68 {
+				device_type = "rtc";
+				compatible = "ds1374";
+				reg = <68>;
+				interrupts = <13 8>;
+				interrupt-parent = <700>;
+			};
 		};
 
 		i2c@3100 {
-- 
1.4.2.3

RE: [PATCH 2/4] powerpc: Add the ds1374 RTC to the mpc8349emds devicetree.

[Joakim Tjernlund]

> -----Original Message-----
> From: 
> linuxppc-dev-bounces+joakim.tjernlund=transmode.se@ozlabs.org 
> [mailto:linuxppc-dev-bounces+joakim.tjernlund=transmode.se@ozl
> abs.org] On Behalf Of Scott Wood
> Sent: den 7 december 2006 18:35
> To: linuxppc-dev@ozlabs.org
> Cc: i2c@lm-sensors.org
> Subject: [PATCH 2/4] powerpc: Add the ds1374 RTC to the 
> mpc8349emds devicetree.
> 
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> ---
>  arch/powerpc/boot/dts/mpc8349emds.dts |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/boot/dts/mpc8349emds.dts 
> b/arch/powerpc/boot/dts/mpc8349emds.dts
> index 50f4886..889a5b8 100644
> --- a/arch/powerpc/boot/dts/mpc8349emds.dts
> +++ b/arch/powerpc/boot/dts/mpc8349emds.dts
> @@ -55,12 +55,22 @@
>  		};
>  
>  		i2c@3000 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
>  			device_type = "i2c";
>  			compatible = "fsl-i2c";
>  			reg = <3000 100>;
>  			interrupts = <e 8>;
>  			interrupt-parent = <700>;
>  			dfsrr;
> +
> +			rtc@68 {
> +				device_type = "rtc";
> +				compatible = "ds1374";
> +				reg = <68>;
> +				interrupts = <13 8>;
> +				interrupt-parent = <700>;
> +			};
>  		};
>  
>  		i2c@3100 {
> -- 
> 1.4.2.3

Nice, I have a question/request though:

I have a ds1337 I2C RTC and to make the current rtc-ds1307 do
the right thing, I need to pass module param
rtc-ds1307.force=0,0x68

I would need some way to tell rtc-ds1307 that I have
a ds1337 device from my dts spec.

 Jocke

Re: [PATCH 2/4] powerpc: Add the ds1374 RTC to the mpc8349emds devicetree.

[Sergei Shtylyov]

Hello.

Joakim Tjernlund wrote:

>>Signed-off-by: Scott Wood <scottwood@freescale.com>
>>---
>> arch/powerpc/boot/dts/mpc8349emds.dts |   10 ++++++++++
>> 1 files changed, 10 insertions(+), 0 deletions(-)

>>diff --git a/arch/powerpc/boot/dts/mpc8349emds.dts 
>>b/arch/powerpc/boot/dts/mpc8349emds.dts
>>index 50f4886..889a5b8 100644
>>--- a/arch/powerpc/boot/dts/mpc8349emds.dts
>>+++ b/arch/powerpc/boot/dts/mpc8349emds.dts
>>@@ -55,12 +55,22 @@
>> 		};
>> 
>> 		i2c@3000 {
>>+			#address-cells = <1>;
>>+			#size-cells = <0>;
>> 			device_type = "i2c";
>> 			compatible = "fsl-i2c";
>> 			reg = <3000 100>;
>> 			interrupts = <e 8>;
>> 			interrupt-parent = <700>;
>> 			dfsrr;
>>+
>>+			rtc@68 {
>>+				device_type = "rtc";
>>+				compatible = "ds1374";
>>+				reg = <68>;
>>+				interrupts = <13 8>;
>>+				interrupt-parent = <700>;
>>+			};
>> 		};
>> 
>> 		i2c@3100 {
>>-- 
>>1.4.2.3

> Nice, I have a question/request though:

> I have a ds1337 I2C RTC and to make the current rtc-ds1307 do
> the right thing, I need to pass module param
> rtc-ds1307.force=0,0x68

> I would need some way to tell rtc-ds1307 that I have
> a ds1337 device from my dts spec.

    That must be achievable by specifiying the "model" property...

>  Jocke

WBR, Sergei