Platform files question

Platform files question

[Michael Sokolov]

Hi there,

Now that we have arch/ppc/platforms and include/asm-ppc/platforms for all
platform-specific files, I have this question for you guys. When I do a new
platform port, should I put the main .h file for the platform in
arch/ppc/platforms or in include/asm-ppc/platforms?

MS

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: Platform files question

[Armin Kuster]

Michael Sokolov wrote:
>
> Hi there,
>
> Now that we have arch/ppc/platforms and include/asm-ppc/platforms for all
> platform-specific files, I have this question for you guys. When I do a new
> platform port, should I put the main .h file for the platform in
> arch/ppc/platforms or in include/asm-ppc/platforms?
>
> MS
>


AFAIK your board header should go in include/asm-ppc/platforms and your
board.c file should go arch/ppc/platforms

-- armin

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: Platform files question

[Dan Malek]

Armin Kuster wrote:


> AFAIK your board header should go in include/asm-ppc/platforms and your
> board.c file should go arch/ppc/platforms

Which is of course true today but a big change from the way the kernel
has evolved.  We used to put all of the include files (or others) that
were unique to a platform (or unused outside of the kernel) together
in lower level directories.  Just a bit of trivia so eveyone understands
why it was done the "old" way and why it may be hard to change to the
"new" way :-).


	-- Dan


** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: Platform files question

[Michael Sokolov]

Armin Kuster <akuster@mvista.com> wrote:

> AFAIK your board header should go in include/asm-ppc/platforms and your
> board.c file should go arch/ppc/platforms

Then are all the platforms that have their headers together with source files
in arch/ppc/platforms and nothing in include/asm-ppc wrong? For example, back
in MVista's 2.2 tree k2.h was in include/asm-ppc, but when I got to the public
tree, which by then was linuxppc_2_4_devel, it moved to arch/ppc/kernel and is
now in arch/ppc/platforms.

MS

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: Platform files question

[Tom Rini]

On Wed, Nov 28, 2001 at 09:14:42AM -0800, Michael Sokolov wrote:
>
> Armin Kuster <akuster@mvista.com> wrote:
>
> > AFAIK your board header should go in include/asm-ppc/platforms and your
> > board.c file should go arch/ppc/platforms
>
> Then are all the platforms that have their headers together with source files
> in arch/ppc/platforms and nothing in include/asm-ppc wrong? For example, back
> in MVista's 2.2 tree k2.h was in include/asm-ppc, but when I got to the public
> tree, which by then was linuxppc_2_4_devel, it moved to arch/ppc/kernel and is
> now in arch/ppc/platforms.

There's no exact way right now.  But it breaks down like this, if you
have a port which does _not_ need to change include/asm-ppc/serial.h,
they can all go in arch/ppc/platforms.  If you change
include/asm-ppc/serial.h AND newBoard_serial.h needs to include
newBoard.h, they both go in include/asm-ppc/platforms/.

If you're 8xx or 8260 tho, they always go in include/asm-ppc/platforms
because of how m8xx/m8260 ports work.

And there's always exceptions to the rule to boot :)

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: Platform files question

[Michael Sokolov]

Tom Rini <trini@kernel.crashing.org> wrote:

> There's no exact way right now.  But it breaks down like this, if you
> have a port which does _not_ need to change include/asm-ppc/serial.h,
> they can all go in arch/ppc/platforms.  If you change
> include/asm-ppc/serial.h AND newBoard_serial.h needs to include
> newBoard.h, they both go in include/asm-ppc/platforms/.

And what if I have a port that has its newBoard_serial.h, but it doesn't need
to include newBoard.h?

MS

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

Re: Platform files question

[Tom Rini]

On Wed, Nov 28, 2001 at 10:54:05AM -0800, Michael Sokolov wrote:
>
> Tom Rini <trini@kernel.crashing.org> wrote:
>
> > There's no exact way right now.  But it breaks down like this, if you
> > have a port which does _not_ need to change include/asm-ppc/serial.h,
> > they can all go in arch/ppc/platforms.  If you change
> > include/asm-ppc/serial.h AND newBoard_serial.h needs to include
> > newBoard.h, they both go in include/asm-ppc/platforms/.
>
> And what if I have a port that has its newBoard_serial.h, but it doesn't need
> to include newBoard.h?

arch/ppc/platforms/newBoard.h,
include/asm-ppc/platforms/newBoard_serial.h.

All of the 6xx/7xx/74xx board.h files in platforms/ are there because of
board_serial.h requiring them.

--
Tom Rini (TR1265)
http://gate.crashing.org/~trini/

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/