linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: msokolov@ivan.Harhan.ORG (Michael Sokolov)
To: linuxppc-dev@lists.linuxppc.org
Subject: Re: A little fix
Date: Wed, 28 Nov 01 09:05:56 PST	[thread overview]
Message-ID: <0111281705.AA27318@ivan.Harhan.ORG> (raw)


Tom,

I think you've goofed a little bit again:

ChangeSet@1.699, 2001-11-27 15:44:22-07:00, trini@opus.bloom.county
  'bootinfo' is wrong, 'bi_record' is right, whoops.

  arch/ppc/boot/common/misc-simple.c
    1.12 01/11/27 15:44:21 trini@opus.bloom.county +3 -5
    struct bootinfo -> struct bi_record.

After this change misc-simple.c doesn't compile due to a missing semicolon, and
even if it compiled it would return the wrong address (we need the start of
bi_recs, not the end). The fix is below.

MS

diff --minimal -Nru a/arch/ppc/boot/common/misc-simple.c b/arch/ppc/boot/common/misc-simple.c
--- a/arch/ppc/boot/common/misc-simple.c	Wed Nov 28 08:53:35 2001
+++ b/arch/ppc/boot/common/misc-simple.c	Wed Nov 28 08:53:35 2001
@@ -63,7 +63,8 @@
 {
 	int timer = 0;
 	char *cp, ch;
-	struct bi_record *rec
+	struct bi_record *rec;
+	struct bi_record *birecs;

 	setup_legacy();
 	com_port = serial_init(0, NULL);
@@ -159,6 +160,7 @@
 	 */
 	rec = (struct bi_record *)_ALIGN((unsigned long)(zimage_size) +
 			(1 << 20) - 1, (1 << 20));
+	birecs = rec;

 	rec->tag = BI_FIRST;
 	rec->size = sizeof(struct bi_record);
@@ -184,5 +186,5 @@
 	rec = (struct bi_record *)((unsigned long)rec + rec->size);
 	puts("Now booting the kernel\n");

-	return rec;
+	return birecs;
 }

** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/

             reply	other threads:[~2001-11-28 17:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-28 17:05 Michael Sokolov [this message]
2001-11-28 23:44 ` A little fix Tom Rini
  -- strict thread matches above, loose matches on Subject: below --
2001-11-27 22:36 Michael Sokolov
2001-11-28  7:25 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0111281705.AA27318@ivan.Harhan.ORG \
    --to=msokolov@ivan.harhan.org \
    --cc=linuxppc-dev@lists.linuxppc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).