From: Segher Boessenkool <segher@kernel.crashing.org>
To: benh@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org, Stefan Roese <sr@denx.de>
Subject: Re: [PATCH] [POWERPC] Add AMCC Glacier 460GT eval board dts
Date: Fri, 21 Mar 2008 12:46:01 +0100 [thread overview]
Message-ID: <011f73a2a2f33e075c20f0d0bb42d4a7@kernel.crashing.org> (raw)
In-Reply-To: <1206090031.8420.67.camel@pasglop>
> As for the DTS, maybe a "compatible" property in the CPU might make
> some
> sense with a content along the lines of "ppc440x6" or whatever rev of
> the 440 core it is.
Good idea, but please _also_ put the exact name in there, first; so
something like
compatible = "AMCC,PowerPC,460GT", "AMCC,ppc440x6";
That way, you can still probe for specific versions where necessary.
This is completely in line with the "generic naming" recommended
practice; the PowerPC binding predates that RP, it really needs to
be updated.
Any reason we keep the device_type here, btw?
Segher
next prev parent reply other threads:[~2008-03-21 11:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 16:15 [PATCH] [POWERPC] Add AMCC Glacier 460GT eval board dts Stefan Roese
2008-03-21 9:00 ` Benjamin Herrenschmidt
2008-03-21 10:54 ` Stefan Roese
2008-03-21 12:24 ` Josh Boyer
2008-03-21 17:28 ` Segher Boessenkool
2008-03-22 1:14 ` Josh Boyer
2008-03-21 11:46 ` Segher Boessenkool [this message]
2008-03-21 11:51 ` Benjamin Herrenschmidt
2008-03-21 11:58 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=011f73a2a2f33e075c20f0d0bb42d4a7@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).