Re: [PATCH 1/1] PCI set flag PCI_SCAN_ALL_PCIE_DEVS for P.A. Semi boards

[Christian Zigotzky <chzigotzky@xenosoft.de>]

Hi Michael,

Many thanks for your help. Did you merge Olof=E2=80=98s patch? I still have t=
o patch the 4.17 source code.

Thanks,
Christian

Sent from my iPhone

> On 19. Mar 2018, at 23:32, Michael Ellerman <mpe@ellerman.id.au> wrote:
>=20
> Bjorn Helgaas <helgaas@kernel.org> writes:
>=20
>>> On Fri, Mar 16, 2018 at 01:55:36PM +0100, Christian Zigotzky wrote:
>>> Bjorn Helgaas created a patch for making PCI_SCAN_ALL_PCIE_DEVS work for=

>>> Root Ports as well as Downstream. Previously PCI_SCAN_ALL_PCIE_DEVS (set=
 by
>>> quirks or the "pci=3Dpcie_scan_all"
>>> kernel parameter) only affected Switch Downstream Ports, not Root Ports.=
 The
>>> problem is, that we have to add always the boot argument "pci=3Dpcie_sca=
n_all"
>>> for using Bjorn's improvements. Without the boot argument
>>> "pci=3Dpcie_scan_all", the kernel doesn't boot on P.A. Semi boards with S=
B600
>>> chipset (SB600 chipset is connected via PCIe x4 to the P.A. Semi=E2=80=99=
s
>>> PA6T-1682M System-on-a-Chip) because the kernel can't find any drives
>>> connected to the SB600 anymore. Olof Johansson has created a patch for
>>> executing "pci=3Dpcie_scan_all" automatically on P.A. Semi boards. With h=
is
>>> patch, we don't need to add 'pci=3Dpcie_scan_all' to the kernel boot arg=
uments
>>> anymore.
>>=20
>> The patch looks fine, but I need a signed-off-by line before I can apply
>> it.  See https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.g=
it/tree/Documentation/process/submitting-patches.rst
>=20
> I'm happy to take it, I've been meaning to check if Olof sent a SOB in
> his original mail but haven't got to it.
>=20
> ...
>=20
> Yes, he did, see below.
>=20
> So I'll merge that, I'll add a Tested-by for you Christian.
>=20
> Christian please don't remove any of the tags when submitting other
> peoples' patches in future.
>=20
> cheers
>=20
>=20
> =46rom a3b390277627b0342c8ccfc16e58679e0d8abdde Mon Sep 17 00:00:00 2001
> From: Olof Johansson <olof@lixom.net>
> Date: Sat, 2 Dec 2017 14:56:36 -0800
> Subject: [PATCH] powerpc/pasemi: set PCI_SCAN_ALL_PCI_DEVS
>=20
> Needed on Amiga X1000 with SB600.
>=20
> Reported-by: Christian Zigotzky <chzigotzky@xenosoft.de>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
> arch/powerpc/platforms/pasemi/pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>=20
> diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/=
pasemi/pci.c
> index 5ff6108..ea54ed2 100644
> --- a/arch/powerpc/platforms/pasemi/pci.c
> +++ b/arch/powerpc/platforms/pasemi/pci.c
> @@ -224,6 +224,8 @@ void __init pas_pci_init(void)
>        return;
>    }
>=20
> +    pci_set_flag(PCI_SCAN_ALL_PCIE_DEVS):
> +
>    for (np =3D NULL; (np =3D of_get_next_child(root, np)) !=3D NULL;)
>        if (np->name && !strcmp(np->name, "pxp") && !pas_add_bridge(np))
>            of_node_get(np);