linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Matthew R. Ochs" <mrochs@linux.vnet.ibm.com>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org,
	helgaas@kernel.org, mauricfo@linux.vnet.ibm.com,
	gwshan@linux.vnet.ibm.com, ruscur@russell.cc,
	ukrishn@linux.vnet.ibm.com, imunsie@au1.ibm.com,
	fbarrat@linux.vnet.ibm.com, clombard@linux.vnet.ibm.com,
	felix@linux.vnet.ibm.com
Subject: Re: [PATCH] cxl: use pcibios_free_controller_deferred() when removing vPHBs
Date: Thu, 18 Aug 2016 12:02:42 -0500	[thread overview]
Message-ID: <0170D6B7-1005-47B5-9DC7-EC55846D2DA2@linux.vnet.ibm.com> (raw)
In-Reply-To: <1471505714-30049-1-git-send-email-andrew.donnellan@au1.ibm.com>

> On Aug 18, 2016, at 2:35 AM, Andrew Donnellan =
<andrew.donnellan@au1.ibm.com> wrote:
>=20
> When cxl removes a vPHB, it's possible that the pci_controller may be =
freed
> before all references to the devices on the vPHB have been released. =
This
> in turn causes an invalid memory access when the devices are =
eventually
> released, as pcibios_release_device() attempts to call the phb's
> release_device hook.
>=20
> In cxl_pci_vphb_remove(), remove the existing call to
> pcibios_free_controller(). Instead, use
> pcibios_free_controller_deferred() to free the pci_controller after =
all
> devices have been released. Export pci_set_host_bridge_release() so we =
can
> do this.
>=20
> Cc: stable@vger.kernel.org
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>

Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>

  reply	other threads:[~2016-08-18 17:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-18  7:35 [PATCH] cxl: use pcibios_free_controller_deferred() when removing vPHBs Andrew Donnellan
2016-08-18 17:02 ` Matthew R. Ochs [this message]
2016-08-19  2:59 ` Ian Munsie
2016-08-22 19:23 ` kbuild test robot
2016-08-30  1:58 ` Andrew Donnellan
2016-08-30  2:36   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0170D6B7-1005-47B5-9DC7-EC55846D2DA2@linux.vnet.ibm.com \
    --to=mrochs@linux.vnet.ibm.com \
    --cc=andrew.donnellan@au1.ibm.com \
    --cc=clombard@linux.vnet.ibm.com \
    --cc=fbarrat@linux.vnet.ibm.com \
    --cc=felix@linux.vnet.ibm.com \
    --cc=gwshan@linux.vnet.ibm.com \
    --cc=helgaas@kernel.org \
    --cc=imunsie@au1.ibm.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mauricfo@linux.vnet.ibm.com \
    --cc=ruscur@russell.cc \
    --cc=ukrishn@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).