From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F51CC433FE for ; Fri, 29 Oct 2021 15:06:31 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CE0A61166 for ; Fri, 29 Oct 2021 15:06:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9CE0A61166 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Hgm3S6sfTz3c7R for ; Sat, 30 Oct 2021 02:06:28 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=VdHWj0+n; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=infradead.org (client-ip=2001:8b0:10b:1:d65d:64ff:fe57:4e05; helo=desiato.infradead.org; envelope-from=geoff@infradead.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256 header.s=desiato.20200630 header.b=VdHWj0+n; dkim-atps=neutral Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Hgm2d1flHz2yNT for ; Sat, 30 Oct 2021 02:05:42 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject: Sender:Reply-To:Content-ID:Content-Description; bh=SiX9UHoKQRXFz7uP18kxGHUXOhLYqA4eqNBdQkR4TXE=; b=VdHWj0+nTUKPpKWf81O53GmJ4F Y7kKTY7MJ2Zcuu77lNqX67xwl83XeEbX0np9vqqR44i+AQylcpAnM1v4qlYv9h29Kya5GKCN2ybE3 W+t52oiDWqFAjYFnW+1N7gFe8c18KfnHZFF2Tn1ky0WyEOyvINHO40OgAXuCfudialdyEi5OpoaKo B/pw1X7LSoGoe6cqWosHKEVzjEwx5OxDuOlTzkAIRMCNRp0Dqu779rbzrQ1EE/5/d+GI/7ilbja7c C4g1+CtTsxilGDlvOj/9Etq7zQgegEtyQsoLdShVbdRgvac18HmoqGjHShEnXTzy9TdCj3Sno6JbZ M0Pz7m3Q==; Received: from [2602:306:c5a2:a380:b27b:25ff:fe2c:51a8] by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgTRS-00D6jk-Vo; Fri, 29 Oct 2021 15:05:15 +0000 Subject: Re: [PATCH 10/13] ps3disk: add error handling support for add_disk() To: Luis Chamberlain , axboe@kernel.dk, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, jim@jtan.com, minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org, richard@nod.at, miquel.raynal@bootlin.com, vigneshr@ti.com, dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com, ira.weiny@intel.com, kbusch@kernel.org, hch@lst.de, sagi@grimberg.me References: <20211015235219.2191207-1-mcgrof@kernel.org> <20211015235219.2191207-11-mcgrof@kernel.org> From: Geoff Levand Message-ID: <01e79b30-8ac0-c384-d57d-7c79e7f244c2@infradead.org> Date: Fri, 29 Oct 2021 08:05:06 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211015235219.2191207-11-mcgrof@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-mtd@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Luis, On 10/15/21 4:52 PM, Luis Chamberlain wrote: > We never checked for errors on add_disk() as this function > returned void. Now that this is fixed, use the shiny new > error handling. > > Signed-off-by: Luis Chamberlain I tested your 20211011-for-axboe-add-disk-error-handling branch on PS3 and the ps3disk changes seem to be working OK. Tested-by: Geoff Levand