From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.embeddedspecialties.com (mail.embeddedspecialties.com [74.94.113.177]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id D83F0DDED2 for ; Wed, 15 Aug 2007 07:41:28 +1000 (EST) From: "Joe Hamman" To: "'Andy Fleming'" References: <1187044669.10295.4.camel@server> <3FE16C0A-892F-4481-999A-A699C0C70BF9@kernel.crashing.org> <013b01c7de23$5baa7d70$6f00a8c0@ESIDT> <1B668DF2-9909-4D43-AAFF-3A2ADFA283B2@freescale.com> <46C1D553.4000201@freescale.com> <018801c7de93$43390e80$6f00a8c0@ESIDT> <46C1EDAA.3070402@freescale.com> <66FE71AE-6AF2-4A2F-91D0-6517B0702C13@freescale.com> <020101c7deb6$4168cd70$6f00a8c0@ESIDT> Subject: RE: [PATCH] [UPDATED] tsec: Allow Ten Bit Interface to be configurable Date: Tue, 14 Aug 2007 16:41:23 -0500 Message-ID: <020b01c7debb$dc28a3d0$6f00a8c0@ESIDT> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: Cc: linuxppc-embedded@ozlabs.org Reply-To: joe.hamman@embeddedspecialties.com List-Id: Linux on Embedded PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > -----Original Message----- > From: Andy Fleming [mailto:afleming@freescale.com] > Sent: Tuesday, August 14, 2007 4:30 PM > To: joe.hamman@embeddedspecialties.com > Cc: 'Scott Wood'; linuxppc-embedded@ozlabs.org > Subject: Re: [PATCH] [UPDATED] tsec: Allow Ten Bit Interface to be > configurable > > > On Aug 14, 2007, at 16:01, Joe Hamman wrote: > > > Hi Andy, > >> > >> I still think it should just be a property of the ethernet node. We > >> aren't describing the TBI, we're describing a setting for the > >> ethernet controller's register. > >> > > > > Like this? Do we need to have one for each ethernet@xxxxxx? > > > Scott and I have been talking, and right now it seems like a better > idea might be to have the TBI address get assigned dynamically, based > on where PHYs aren't. > > It's non-trivial to do (though not difficult), but this way we won't > have to regret creating a bad interface. You just need to look at > the mdio bus, and find out which addresses responded. Then you > create a variable in the gfar_private structure to hold what it gets > set to, and make sure that gfar_configure_serdes uses that value > instead of the TBIPA constant. Sounds like a good plan. I'll try to put something together and post for comments. Thanks, Joe