From: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
linuxppc-dev@lists.ozlabs.org, mpe@ellerman.id.au,
gwshan@linux.vnet.ibm.com
Subject: Re: [PATCH v4] powerpc/pseries: use pci_host_bridge.release_fn() to kfree(phb)
Date: Fri, 12 Aug 2016 08:39:23 -0300 [thread overview]
Message-ID: <03219ae6-9f9e-fadb-7876-c33b30484bd4@linux.vnet.ibm.com> (raw)
In-Reply-To: <42f3e4a5-32bd-5c49-0bd9-7db5d779655c@au1.ibm.com>
Michael,
On 08/12/2016 02:54 AM, Gavin Shan wrote:
> I don't have more obvious comments except below one nitpicky:
I just addressed/replied this in the other e-mail; i think it's OK,
and Andrew/cxl is OK w/ it too.
> Reviewed-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
On 08/12/2016 03:06 AM, Andrew Donnellan wrote:
>> Suggested-By: Gavin Shan <gwshan@linux.vnet.ibm.com>
>> Signed-off-by: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
>
> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> Tested-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> # cxl
>
> Does this justify a Cc: stable?
I'd think so, since this prevents an oops & crash (w/ panic_on_oops).
Do you agree?
Thanks!
--
Mauricio Faria de Oliveira
IBM Linux Technology Center
prev parent reply other threads:[~2016-08-12 11:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 20:25 [PATCH v4] powerpc/pseries: use pci_host_bridge.release_fn() to kfree(phb) Mauricio Faria de Oliveira
2016-08-12 5:54 ` Gavin Shan
2016-08-12 6:03 ` Andrew Donnellan
2016-08-12 11:35 ` Mauricio Faria de Oliveira
2016-08-12 6:06 ` Andrew Donnellan
2016-08-12 11:39 ` Mauricio Faria de Oliveira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03219ae6-9f9e-fadb-7876-c33b30484bd4@linux.vnet.ibm.com \
--to=mauricfo@linux.vnet.ibm.com \
--cc=andrew.donnellan@au1.ibm.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).