From: Kumar Gala <kumar.gala@freescale.com>
To: "Fleming Andy-afleming" <afleming@freescale.com>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: RFC: performance monitor/oprofile support for e500
Date: Sun, 31 Oct 2004 23:43:52 -0600 [thread overview]
Message-ID: <0329659A-2BC9-11D9-A949-000393DBC2E8@freescale.com> (raw)
In-Reply-To: <642F8D42-2A11-11D9-A860-000393C30512@freescale.com>
Andy,
Some feedback:
* Any reason to get ride of the 604 code now,w/o replacing it with
something?
* Why have you introduce two CPU features (CPU_FTR_CAN_USE_PMON_INTR &
CPU_FTR_FSL_BOOKE_PMON) you dont use ?
* In the PerformanceMonitor can't you use regs->nip for the same
purpose of regs->sia?
* Does arch/ppc/kernel/perfmon.c really need all the headers you are
including?
* Does perfmon.c make more sense as perfmon_fsl_booke.c
* op_ppc32_setup, I'd prefer the saving & restoring of the perf_irq
like arch/ppc64/oprofile/common.c does
* a number of issues related to SMP
* any reason get_kernel is a function?
* Do ctr_read & ctr_write really belong in op_impl.h, especially since
different implementations will be needed for classic ppc.
I sent a note to Paul M. about putting num_counters into cpu_specs
table.
- kumar
On Oct 29, 2004, at 8:16 PM, Fleming Andy-afleming wrote:
> This patch:
> * Adds support for using the performance monitor counters and the
> associated interrupt, but only enables it currently for e500
> * Removes the old 604 performance monitor code, suggested by various
> people on IRC
> * Adds oprofile support for the e500, with potential for expansion to
> support other ppc32 processors
>
> Andy Fleming
> NCSG Open Source Team
> Freescale Semiconductor, Inc
> <oprofile-kernel-patch><ATT2027925.txt>
next prev parent reply other threads:[~2004-11-01 5:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-30 1:16 RFC: performance monitor/oprofile support for e500 Andy Fleming
2004-10-30 3:29 ` Eugene Surovegin
2004-11-01 5:43 ` Kumar Gala [this message]
2004-11-01 17:03 ` Andy Fleming
2004-11-01 17:27 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0329659A-2BC9-11D9-A949-000393DBC2E8@freescale.com \
--to=kumar.gala@freescale.com \
--cc=afleming@freescale.com \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox