* [PATCH] ide: fix warning comparing pointer to 0
@ 2021-03-11 9:48 Jiapeng Chong
2021-03-11 15:12 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-03-11 9:48 UTC (permalink / raw)
To: davem; +Cc: Jiapeng Chong, linux-kernel, linux-ide, paulus, linuxppc-dev
Fix the following coccicheck warning:
./drivers/ide/pmac.c:1680:38-39: WARNING comparing pointer to 0.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/ide/pmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c
index ea0b064..d5171e0 100644
--- a/drivers/ide/pmac.c
+++ b/drivers/ide/pmac.c
@@ -1677,7 +1677,7 @@ static int pmac_ide_init_dma(ide_hwif_t *hwif, const struct ide_port_info *d)
/* We won't need pci_dev if we switch to generic consistent
* DMA routines ...
*/
- if (dev == NULL || pmif->dma_regs == 0)
+ if (!dev || pmif->dma_regs)
return -ENODEV;
/*
* Allocate space for the DBDMA commands.
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ide: fix warning comparing pointer to 0
2021-03-11 9:48 [PATCH] ide: fix warning comparing pointer to 0 Jiapeng Chong
@ 2021-03-11 15:12 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2021-03-11 15:12 UTC (permalink / raw)
To: Jiapeng Chong, davem; +Cc: linux-kernel, linux-ide, paulus, linuxppc-dev
On 3/11/21 2:48 AM, Jiapeng Chong wrote:
> Fix the following coccicheck warning:
>
> ./drivers/ide/pmac.c:1680:38-39: WARNING comparing pointer to 0.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/ide/pmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c
> index ea0b064..d5171e0 100644
> --- a/drivers/ide/pmac.c
> +++ b/drivers/ide/pmac.c
> @@ -1677,7 +1677,7 @@ static int pmac_ide_init_dma(ide_hwif_t *hwif, const struct ide_port_info *d)
> /* We won't need pci_dev if we switch to generic consistent
> * DMA routines ...
> */
> - if (dev == NULL || pmif->dma_regs == 0)
> + if (!dev || pmif->dma_regs)
> return -ENODEV;
This looks utterly broken - the warning is most definitely about
dma_regs, not dev, and you swapped the condition (failing on dma_regs
being set, not NULL).
I'd just leave this one alone, drivers/ide/ should be going away soon.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-11 15:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-11 9:48 [PATCH] ide: fix warning comparing pointer to 0 Jiapeng Chong
2021-03-11 15:12 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).