linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: LEROY Christophe <christophe.leroy@c-s.fr>
Cc: mikey@neuling.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2] powerpc/tm: Print 64-bits MSR
Date: Wed, 8 Aug 2018 12:50:29 -0300	[thread overview]
Message-ID: <0378869f-cd56-db1c-f359-5b5791d9603f@debian.org> (raw)
In-Reply-To: <20180807205718.Horde.hQCYOtyzfY7xFtxCwRj2Iw1@messagerie.si.c-s.fr>

Hi Leroy,

On 08/07/2018 03:57 PM, LEROY Christophe wrote:
> Breno Leitao <leitao@debian.org> a écrit :

>> On 08/07/2018 02:15 PM, Christophe LEROY wrote:
>>> Le 07/08/2018 à 15:35, Breno Leitao a écrit :

>>> I think it would be better to change 'reason' to 'unsigned long' instead of
>>> replacing it by regs->msr for the printk.
>>
>> That was my initial approach, but this code seems to run on 32 bits system,
>> and I do not want to change the whole 'reason' bit width without having a 32
>> bits to test, at least.
> 
> But 'unsigned long' is still 32 bits on ppc32, so it makes no difference with
> 'unsigned int'
> And I will test it for you if needed

Cool, I really appreciate it, and I would definitely need it once I have a
more intrusive HTM patchset I am working on.

Regarding this one, I think the change is so simple as-is that  I would
prefer to continue with the v2 patch, if you do not mind.

Thank you!

  reply	other threads:[~2018-08-08 15:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-07  0:32 [PATCH] powerpc/tm: Print 64-bits MSR Breno Leitao
2018-08-07  1:17 ` Michael Neuling
2018-08-07 13:35   ` [PATCH v2] " Breno Leitao
2018-08-07 15:50     ` Segher Boessenkool
2018-08-07 17:15     ` Christophe LEROY
2018-08-07 18:41       ` Breno Leitao
2018-08-07 18:57         ` LEROY Christophe
2018-08-08 15:50           ` Breno Leitao [this message]
2018-10-04  6:14     ` [v2] " Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0378869f-cd56-db1c-f359-5b5791d9603f@debian.org \
    --to=leitao@debian.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mikey@neuling.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).