From: Sathyanarayanan Kuppuswamy <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Vidya Sagar <vidyas@nvidia.com>, Bjorn Helgaas <helgaas@kernel.org>
Cc: mmaddireddy@nvidia.com, kthota@nvidia.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
jonathanh@nvidia.com, vsethi@nvidia.com, oohall@gmail.com,
bhelgaas@google.com, treding@nvidia.com,
linuxppc-dev@lists.ozlabs.org, sagar.tv@gmail.com
Subject: Re: [PATCH V1] PCI/AER: Configure ECRC only AER is native
Date: Wed, 11 Jan 2023 21:06:15 -0800 [thread overview]
Message-ID: <0406e96b-56fc-d9bd-6ef8-88157ce64e1f@linux.intel.com> (raw)
In-Reply-To: <4a764544-189f-65e0-7d77-84995299721d@nvidia.com>
On 1/11/23 8:59 PM, Vidya Sagar wrote:
>
>
> On 1/12/2023 9:18 AM, Sathyanarayanan Kuppuswamy wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On 1/11/23 7:33 PM, Vidya Sagar wrote:
>>> I think we still need bios option. For example, consider a system where BIOS needs to keep ECRC enabled for integrity reasons but if kernel doesn't want it for perf reasons, then, kernel can always use 'ecrc=off' option.
>>
>> I agree that "on" and "off" option makes sense. Since the kernel defaults ecrc setting to "bios", why again allow it as a command line option?
>
> Agree. "on" and "off" are fine but "default" is redundant. Do you want me to push a change to remove that as part of this patch itself? I think
> it is more like a cleanup and should go separately.
IMO, the "bios" option cleanup and command line update from Bjorn can be in one patch, and your change could be a separate patch. But it is
up to you and Bjorn.
>
>>
>> --
>> Sathyanarayanan Kuppuswamy
>> Linux Kernel Developer
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
next prev parent reply other threads:[~2023-01-12 5:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 20:31 [PATCH V1] PCI/AER: Configure ECRC only AER is native Vidya Sagar
2023-01-11 21:42 ` Sathyanarayanan Kuppuswamy
2023-01-11 23:10 ` Bjorn Helgaas
2023-01-11 23:27 ` Sathyanarayanan Kuppuswamy
2023-01-12 3:33 ` Vidya Sagar
2023-01-12 3:48 ` Sathyanarayanan Kuppuswamy
2023-01-12 4:59 ` Vidya Sagar
2023-01-12 5:06 ` Sathyanarayanan Kuppuswamy [this message]
2023-01-12 7:12 ` Vidya Sagar
2023-01-12 18:23 ` Bjorn Helgaas
2023-01-12 7:21 ` [PATCH V2] " Vidya Sagar
2023-01-12 18:25 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0406e96b-56fc-d9bd-6ef8-88157ce64e1f@linux.intel.com \
--to=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=kthota@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mmaddireddy@nvidia.com \
--cc=oohall@gmail.com \
--cc=sagar.tv@gmail.com \
--cc=treding@nvidia.com \
--cc=vidyas@nvidia.com \
--cc=vsethi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).