From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nommos.sslcatacombnetworking.com (nommos.sslcatacombnetworking.com [67.18.224.114]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 8387ADDE44 for ; Sat, 13 Jan 2007 05:58:20 +1100 (EST) In-Reply-To: <20070112095213.GA24536@lst.de> References: <20070112095213.GA24536@lst.de> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <048A2BB9-66FF-494F-8A6B-2649D8B96DBD@kernel.crashing.org> From: Kumar Gala Subject: Re: [patch][5/5] powerpc: Add the general support for Embedded Floating-Point instructions Date: Fri, 12 Jan 2007 12:57:36 -0600 To: Christoph Hellwig Cc: linuxppc-dev@ozlabs.org, paulus@samba.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Jan 12, 2007, at 3:52 AM, Christoph Hellwig wrote: > On Fri, Jan 12, 2007 at 01:31:02PM +0800, ebony.zhu@freescale.com > wrote: >> +ifeq ($(CONFIG_SPE),y) >> +ifneq ($(CONFIG_MATH_EMULATION),y) >> +core-y += arch/powerpc/math-emu/ >> +endif >> +endif >> core-$(CONFIG_MATH_EMULATION) += arch/powerpc/math-emu/ > > This statement doesn't make any sense. I guess you always want to > build arch/powerpc/math-emu if CONFIG_SPE is set, right? The proper > way to do that is to force CONFIG_MATH_EMULATION in the Kconfig. > > Then again we need a really good explanation why CONFIG_SPE should > force the math emulation to be built. I'm a little confused if there is a question about the approach taken? Are you asking is there some way of doing the exception handling w/o fully emulating the instruction? Agree that the build system modifications in this patch set need some fixing, just trying to understand if there is a larger design query here or not? - k