From: Sourabh Jain <sourabhjain@linux.ibm.com>
To: Shivang Upadhyay <shivangu@linux.ibm.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: adityag@linux.ibm.com, adri.vero.dev@gmail.com,
anushree.mathur@linux.vnet.ibm.com, chleroy@kernel.org,
maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com
Subject: Re: [PATCH v2] ppc/fadump: collect dump if the collected size is lesser than reserved
Date: Thu, 27 Aug 2026 12:39:33 +0530 [thread overview]
Message-ID: <04f38671-f894-40ef-94b2-f24e2bd42474@linux.ibm.com> (raw)
In-Reply-To: <7ed10640c0b27403d7e9ef9807b957cff59eba60.camel@linux.ibm.com>
On 27/08/26 12:06, Shivang Upadhyay wrote:
> On Thu, 2026-08-27 at 11:05 +0530, Sourabh Jain wrote:
>>> bytes_dumped <= source_len));
>> Do we really need region_collected variable? Can't we manage with rc
>> only?
>>
>> Is bytes_dumped < source_len is good enough instead of <=. There are
>> a
>> couple of warnings/errors reported by the checkpatch script.
>> Please address them in the next version.
>>
>> - Sourabh Jain
>>
> Hi Sourabh,
>
> bytes_dumped < source_len should also be correct, but "<=" is more
> expressive. Why not leave such optimizations to compiler.
>
> For the region_collected, RC should be used to manage the return code,
> so I as per me it is more appropriate to use new variable here. Or
> maybe, type the condition in the bracket itself(?).
Yes this also works.
- Sourabh Jain
>
> Thanks for pointing out the checkpatch bugs, I'll send a revision soon.
>
> ~Shivang.
prev parent reply other threads:[~2026-08-27 7:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-26 12:56 [PATCH v2] ppc/fadump: collect dump if the collected size is lesser than reserved Shivang Upadhyay
2026-08-27 5:35 ` Sourabh Jain
2026-08-27 6:36 ` Shivang Upadhyay
2026-08-27 7:09 ` Sourabh Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04f38671-f894-40ef-94b2-f24e2bd42474@linux.ibm.com \
--to=sourabhjain@linux.ibm.com \
--cc=adityag@linux.ibm.com \
--cc=adri.vero.dev@gmail.com \
--cc=anushree.mathur@linux.vnet.ibm.com \
--cc=chleroy@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=shivangu@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox