* [PATCH] powerpc/time: Calculate proper wday
@ 2018-08-29 7:54 Joakim Tjernlund
[not found] ` <CA+7wUsxbYGAuwE--AukCCYA8H4CQj1tv31nAOv256u9tkDENKg@mail.gmail.com>
0 siblings, 1 reply; 2+ messages in thread
From: Joakim Tjernlund @ 2018-08-29 7:54 UTC (permalink / raw)
To: linuxppc-dev
to_tm() hardcodes wday to -1 as "No-one uses the day of the week".
But recently rtc driver ds1307 does care and tries to correct wday.
Add wday calculation(stolen from rtc_time64_to_tm) to to_tm() to please ds1307.
Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
---
arch/powerpc/kernel/time.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c
index fe6f3a285455..f4a09ee01944 100644
--- a/arch/powerpc/kernel/time.c
+++ b/arch/powerpc/kernel/time.c
@@ -1160,6 +1160,9 @@ void to_tm(int tim, struct rtc_time * tm)
day = tim / SECDAY;
hms = tim % SECDAY;
+ /* day of the week, 1970-01-01 was a Thursday */
+ tm->tm_wday = (day + 4) % 7;
+
/* Hours, minutes, seconds are easy */
tm->tm_hour = hms / 3600;
tm->tm_min = (hms % 3600) / 60;
@@ -1180,11 +1183,6 @@ void to_tm(int tim, struct rtc_time * tm)
/* Days are what is left over (+1) from all that. */
tm->tm_mday = day + 1;
-
- /*
- * No-one uses the day of the week.
- */
- tm->tm_wday = -1;
}
EXPORT_SYMBOL(to_tm);
--
2.16.4
^ permalink raw reply related [flat|nested] 2+ messages in thread[parent not found: <CA+7wUsxbYGAuwE--AukCCYA8H4CQj1tv31nAOv256u9tkDENKg@mail.gmail.com>]
* Re: [PATCH] powerpc/time: Calculate proper wday [not found] ` <CA+7wUsxbYGAuwE--AukCCYA8H4CQj1tv31nAOv256u9tkDENKg@mail.gmail.com> @ 2018-09-18 8:27 ` Joakim Tjernlund 0 siblings, 0 replies; 2+ messages in thread From: Joakim Tjernlund @ 2018-09-18 8:27 UTC (permalink / raw) To: malat@debian.org; +Cc: linuxppc-dev@lists.ozlabs.org, arnd@arndb.de T24gVHVlLCAyMDE4LTA5LTE4IGF0IDEwOjA4ICswMjAwLCBNYXRoaWV1IE1hbGF0ZXJyZSB3cm90 ZToNCj4gDQo+IA0KPiBPbiBXZWQsIEF1ZyAyOSwgMjAxOCBhdCAxMDowMyBBTSBKb2FraW0gVGpl cm5sdW5kIDxqb2FraW0udGplcm5sdW5kQGluZmluZXJhLmNvbT4gd3JvdGU6DQo+ID4NCj4gPiB0 b190bSgpIGhhcmRjb2RlcyB3ZGF5IHRvIC0xIGFzICJOby1vbmUgdXNlcyB0aGUgZGF5IG9mIHRo ZSB3ZWVrIi4NCj4gPiBCdXQgcmVjZW50bHkgcnRjIGRyaXZlciBkczEzMDcgZG9lcyBjYXJlIGFu ZCB0cmllcyB0byBjb3JyZWN0IHdkYXkuDQo+ID4NCj4gPiBBZGQgd2RheSBjYWxjdWxhdGlvbihz dG9sZW4gZnJvbSBydGNfdGltZTY0X3RvX3RtKSB0byB0b190bSgpIHRvIHBsZWFzZSBkczEzMDcu DQo+IA0KPiBJcyB0aGlzIHN0aWxsIGFuIGlzc3VlIGFmdGVyOg0KPiANCj4gMzRlZmFiZTQxODk1 IHBvd2VycGM6IHJlbW92ZSB1bnVzZWQgdG9fdG0oKSBoZWxwZXINCg0KTm8sIGl0IGlzIG5vdCBh biBpc3N1ZSBhbnltb3JlLiBZb3UgY2FuIGRyb3AgdGhpcyBwYXRjaC4NCg0KIEpvY2tlDQoNCj4g DQo+ID8NCj4gDQo+ID4gU2lnbmVkLW9mZi1ieTogSm9ha2ltIFRqZXJubHVuZCA8am9ha2ltLnRq ZXJubHVuZEBpbmZpbmVyYS5jb20+DQo+ID4gLS0tDQo+ID4gIGFyY2gvcG93ZXJwYy9rZXJuZWwv dGltZS5jIHwgOCArKystLS0tLQ0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCsp LCA1IGRlbGV0aW9ucygtKQ0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL2FyY2gvcG93ZXJwYy9rZXJu ZWwvdGltZS5jIGIvYXJjaC9wb3dlcnBjL2tlcm5lbC90aW1lLmMNCj4gPiBpbmRleCBmZTZmM2Ey ODU0NTUuLmY0YTA5ZWUwMTk0NCAxMDA2NDQNCj4gPiAtLS0gYS9hcmNoL3Bvd2VycGMva2VybmVs L3RpbWUuYw0KPiA+ICsrKyBiL2FyY2gvcG93ZXJwYy9rZXJuZWwvdGltZS5jDQo+ID4gQEAgLTEx NjAsNiArMTE2MCw5IEBAIHZvaWQgdG9fdG0oaW50IHRpbSwgc3RydWN0IHJ0Y190aW1lICogdG0p DQo+ID4gICAgICAgICBkYXkgPSB0aW0gLyBTRUNEQVk7DQo+ID4gICAgICAgICBobXMgPSB0aW0g JSBTRUNEQVk7DQo+ID4NCj4gPiArICAgICAgIC8qIGRheSBvZiB0aGUgd2VlaywgMTk3MC0wMS0w MSB3YXMgYSBUaHVyc2RheSAqLw0KPiA+ICsgICAgICAgdG0tPnRtX3dkYXkgPSAoZGF5ICsgNCkg JSA3Ow0KPiA+ICsNCj4gPiAgICAgICAgIC8qIEhvdXJzLCBtaW51dGVzLCBzZWNvbmRzIGFyZSBl YXN5ICovDQo+ID4gICAgICAgICB0bS0+dG1faG91ciA9IGhtcyAvIDM2MDA7DQo+ID4gICAgICAg ICB0bS0+dG1fbWluID0gKGhtcyAlIDM2MDApIC8gNjA7DQo+ID4gQEAgLTExODAsMTEgKzExODMs NiBAQCB2b2lkIHRvX3RtKGludCB0aW0sIHN0cnVjdCBydGNfdGltZSAqIHRtKQ0KPiA+DQo+ID4g ICAgICAgICAvKiBEYXlzIGFyZSB3aGF0IGlzIGxlZnQgb3ZlciAoKzEpIGZyb20gYWxsIHRoYXQu ICovDQo+ID4gICAgICAgICB0bS0+dG1fbWRheSA9IGRheSArIDE7DQo+ID4gLQ0KPiA+IC0gICAg ICAgLyoNCj4gPiAtICAgICAgICAqIE5vLW9uZSB1c2VzIHRoZSBkYXkgb2YgdGhlIHdlZWsuDQo+ ID4gLSAgICAgICAgKi8NCj4gPiAtICAgICAgIHRtLT50bV93ZGF5ID0gLTE7DQo+ID4gIH0NCj4g PiAgRVhQT1JUX1NZTUJPTCh0b190bSk7DQo+ID4NCj4gPiAtLQ0KPiA+IDIuMTYuNA0KDQo= ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-18 8:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-29 7:54 [PATCH] powerpc/time: Calculate proper wday Joakim Tjernlund
[not found] ` <CA+7wUsxbYGAuwE--AukCCYA8H4CQj1tv31nAOv256u9tkDENKg@mail.gmail.com>
2018-09-18 8:27 ` Joakim Tjernlund
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).