From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: "Cédric Le Goater" <clg@kaod.org>, linuxppc-dev@lists.ozlabs.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>
Subject: Re: [PATCH 03/23] powerpc/pseries/eeh: Make pseries_pcibios_bus_add_device() static
Date: Mon, 21 Dec 2020 09:07:17 +0100 [thread overview]
Message-ID: <0525356c-435b-6145-00b6-451ae24880e5@csgroup.eu> (raw)
In-Reply-To: <20201221074222.403894-4-clg@kaod.org>
Le 21/12/2020 à 08:42, Cédric Le Goater a écrit :
> It fixes this W=1 compile error:
Explain why it can be made static, not just that it does fix a W=1 compile error,
because there are several possible ways to fix such a warning.
>
> ../arch/powerpc/platforms/pseries/eeh_pseries.c:46:6: error: no previous prototype for ‘pseries_pcibios_bus_add_device’ [-Werror=missing-prototypes]
> 46 | void pseries_pcibios_bus_add_device(struct pci_dev *pdev)
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: dae7253f9f78 ("powerpc/pseries: Add pseries SR-IOV Machine dependent calls")
> Cc: Alexey Kardashevskiy <aik@ozlabs.ru>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> arch/powerpc/platforms/pseries/eeh_pseries.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/eeh_pseries.c b/arch/powerpc/platforms/pseries/eeh_pseries.c
> index cf024fa37bda..de45ceb634f9 100644
> --- a/arch/powerpc/platforms/pseries/eeh_pseries.c
> +++ b/arch/powerpc/platforms/pseries/eeh_pseries.c
> @@ -43,7 +43,7 @@ static int ibm_get_config_addr_info;
> static int ibm_get_config_addr_info2;
> static int ibm_configure_pe;
>
> -void pseries_pcibios_bus_add_device(struct pci_dev *pdev)
> +static void pseries_pcibios_bus_add_device(struct pci_dev *pdev)
> {
> struct pci_dn *pdn = pci_get_pdn(pdev);
>
>
next prev parent reply other threads:[~2020-12-21 8:27 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 7:41 [PATCH 00/23] powerpc: Fix W=1 compile errors Cédric Le Goater
2020-12-21 7:42 ` [PATCH 01/23] powerpc/mm: Include __find_linux_pte() prototype Cédric Le Goater
2020-12-21 7:42 ` [PATCH 02/23] powerpc/pseries/ras: Remove unused variable 'status' Cédric Le Goater
2020-12-21 8:06 ` Christophe Leroy
2020-12-21 7:42 ` [PATCH 03/23] powerpc/pseries/eeh: Make pseries_pcibios_bus_add_device() static Cédric Le Goater
2020-12-21 8:07 ` Christophe Leroy [this message]
2020-12-21 7:42 ` [PATCH 04/23] powerpc/pseries/ras: Make init_ras_hotplug_IRQ() static Cédric Le Goater
2020-12-21 8:07 ` Christophe Leroy
2020-12-21 7:42 ` [PATCH 05/23] powerpc/pmem: Include pmem prototypes Cédric Le Goater
2020-12-21 7:42 ` [PATCH 06/23] powerpc/setup_64: Make some routines static Cédric Le Goater
2020-12-21 8:08 ` Christophe Leroy
2020-12-21 7:42 ` [PATCH 07/23] powerpc/mce: Include prototypes Cédric Le Goater
2020-12-21 7:42 ` [PATCH 08/23] powerpc/smp: Include tick_broadcast() prototype Cédric Le Goater
2020-12-21 7:42 ` [PATCH 09/23] powerpc/smp: Make debugger_ipi_callback() static Cédric Le Goater
2020-12-21 7:42 ` [PATCH 10/23] powerpc/optprobes: Remove unused routine patch_imm32_load_insns() Cédric Le Goater
2020-12-21 8:14 ` Christophe Leroy
2020-12-21 7:42 ` [PATCH 11/23] powerpc/optprobes: Make patch_imm64_load_insns() static Cédric Le Goater
2020-12-21 7:42 ` [PATCH 12/23] powerpc/mm: Declare some prototypes Cédric Le Goater
2020-12-21 7:42 ` [PATCH 13/23] powerpc/mm: Move hpte_insert_repeating() prototype Cédric Le Goater
2020-12-21 8:16 ` Christophe Leroy
2020-12-21 7:42 ` [PATCH 14/23] powerpc/mm: Declare preload_new_slb_context() prototype Cédric Le Goater
2020-12-21 7:42 ` [PATCH 15/23] powerpc/mm/hugetlb: Make pseries_alloc_bootmem_huge_page() static Cédric Le Goater
2020-12-21 7:42 ` [PATCH 16/23] powerpc/mm: Declare arch_report_meminfo() prototype Cédric Le Goater
2020-12-21 7:42 ` [PATCH 17/23] powerpc/watchdog: Declare soft_nmi_interrupt() prototype Cédric Le Goater
2020-12-21 8:48 ` Christophe Leroy
2021-01-04 14:03 ` Cédric Le Goater
2020-12-21 7:42 ` [PATCH 18/23] KVM: PPC: Make the VMX instruction emulation routines static Cédric Le Goater
2020-12-21 7:42 ` [PATCH 19/23] KVM: PPC: Book3S HV: Include prototypes Cédric Le Goater
2020-12-21 7:42 ` [PATCH 20/23] KVM: PPC: Book3S HV: Declare some prototypes Cédric Le Goater
2020-12-21 7:42 ` [PATCH 21/23] powerpc/pseries: Make IOV setup routines static Cédric Le Goater
2020-12-21 7:42 ` [PATCH 22/23] powerpc/pcidn: " Cédric Le Goater
2020-12-21 7:42 ` [PATCH 23/23] powerpc/pseries/eeh: Make pseries_send_allow_unfreeze() static Cédric Le Goater
2020-12-21 8:49 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0525356c-435b-6145-00b6-451ae24880e5@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=aik@ozlabs.ru \
--cc=clg@kaod.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).