[PATCH] floppy: ERROR: that open brace { should be on the previous line

[PATCH] floppy: ERROR: that open brace { should be on the previous line

[zhangyongle001]

Fix twoce occurrences of the checkpatch.pl error:
ERROR: that open brace { should be on the previous line

Signed-off-by: zhangyongle <zhangyongle001@208suo.com>
---
  arch/powerpc/include/asm/floppy.h | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/powerpc/include/asm/floppy.h 
b/arch/powerpc/include/asm/floppy.h
index f8ce178b43b7..1ae67d2629be 100644
--- a/arch/powerpc/include/asm/floppy.h
+++ b/arch/powerpc/include/asm/floppy.h
@@ -163,16 +163,14 @@ static int hard_dma_setup(char *addr, unsigned 
long size, int mode, int io)
  	return 0;
  }

-static struct fd_dma_ops real_dma_ops =
-{
+static struct fd_dma_ops real_dma_ops = {
  	._disable_dma = disable_dma,
  	._free_dma = free_dma,
  	._get_dma_residue = get_dma_residue,
  	._dma_setup = hard_dma_setup
  };

-static struct fd_dma_ops virt_dma_ops =
-{
+static struct fd_dma_ops virt_dma_ops = {
  	._disable_dma = vdma_disable_dma,
  	._free_dma = vdma_nop,
  	._get_dma_residue = vdma_get_dma_residue,
-- 
2.40.1

Re: [PATCH] floppy: ERROR: that open brace { should be on the previous line

[Christophe Leroy]

Hello,

Le 20/07/2023 à 12:17, zhangyongle001@208suo.com a écrit :
> [Vous ne recevez pas souvent de courriers de zhangyongle001@208suo.com. 
> D?couvrez pourquoi ceci est important ? 
> https://aka.ms/LearnAboutSenderIdentification ]
> 
> Fix twoce occurrences of the checkpatch.pl error:
> ERROR: that open brace { should be on the previous line


Can you please explain the purpose of those changes ? Do you use some 
tools that get disturbed by such cosmetic errors ? Otherwise what is 
your reason ?

We don't accept such standelone minor cosmetic changes at the first 
place because it looks like a waste of time.

If you have major reasons to want those changes, please re-submit with a 
details explanation in the commit message.

Thanks
Christophe



> 
> Signed-off-by: zhangyongle <zhangyongle001@208suo.com>
> ---
>   arch/powerpc/include/asm/floppy.h | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/powerpc/include/asm/floppy.h
> b/arch/powerpc/include/asm/floppy.h
> index f8ce178b43b7..1ae67d2629be 100644
> --- a/arch/powerpc/include/asm/floppy.h
> +++ b/arch/powerpc/include/asm/floppy.h
> @@ -163,16 +163,14 @@ static int hard_dma_setup(char *addr, unsigned
> long size, int mode, int io)
>         return 0;
>   }
> 
> -static struct fd_dma_ops real_dma_ops =
> -{
> +static struct fd_dma_ops real_dma_ops = {
>         ._disable_dma = disable_dma,
>         ._free_dma = free_dma,
>         ._get_dma_residue = get_dma_residue,
>         ._dma_setup = hard_dma_setup
>   };
> 
> -static struct fd_dma_ops virt_dma_ops =
> -{
> +static struct fd_dma_ops virt_dma_ops = {
>         ._disable_dma = vdma_disable_dma,
>         ._free_dma = vdma_nop,
>         ._get_dma_residue = vdma_get_dma_residue,
> -- 
> 2.40.1
> 

Re: [PATCH] floppy: ERROR: that open brace { should be on the previous line

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 2452 bytes --]

On Fri, Aug 04, 2023 at 04:05:09PM +0000, Christophe Leroy wrote:
> Hello,
> 
> Le 20/07/2023 à 12:17, zhangyongle001@208suo.com a écrit :
> > [Vous ne recevez pas souvent de courriers de zhangyongle001@208suo.com. 
> > D?couvrez pourquoi ceci est important ? 
> > https://aka.ms/LearnAboutSenderIdentification ]
> > 
> > Fix twoce occurrences of the checkpatch.pl error:
> > ERROR: that open brace { should be on the previous line
> 
> 
> Can you please explain the purpose of those changes ? Do you use some 
> tools that get disturbed by such cosmetic errors ? Otherwise what is 
> your reason ?

Hi,

208suo.com people do checkpatch fixes (that is, they run
scripts/checkpatch.pl -f <random source file> then try to make the script
happy). Steven warned them to not submitting such patches again [1] but
they keep spamming maintainers with checkpatch patches (ignoring the review
warning). I voiced this concern when reviewing one of their patches and
Jani replied that such one-way interaction with kernel communty is
detrimental [2].

The exact same situation happened last year involving developers from
cdjrlc.com domain. They also did trivial patches, including mostly
(and notoriously known for) redundant word stripping. While some of these
patches were accepted, others were not with reviews requesting changes in
v2, yet they also ignored reviews. In fact, in the early waves of 208suo.com
patches, they used the same email infra as 208suo.com people and they sent
patches as HTML emails (which were rejected by mailing lists obviously)
so that the latter people have to send their patches on their behalf
(but corrupted since 208suo.com people used Roundcube instead of
git-send-email(1)).

Regarding 208suo.com's mail infra, after I pointed out this [3], they
changed the infra so that patches sent didn't get corrupted. Thus, they did
listen in regard of tooling and infra changes, but they deliberately
doesn't answer code reviews.

Thanks.

[1]: https://lore.kernel.org/lkml/20230720134501.01f9f1de@gandalf.local.home/
[2]: https://lore.kernel.org/lkml/87cz07vvwu.fsf@intel.com/
[3]: https://lore.kernel.org/lkml/ZJK7sC4i+MK98k%2F+@debian.me/

> 
> We don't accept such standelone minor cosmetic changes at the first 
> place because it looks like a waste of time.

PS: And in fact, complicating stable backports...

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]