From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 8A8352C007E for ; Tue, 28 Jan 2014 09:06:58 +1100 (EST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: [PATCH 1/2][v6] driver/memory:Move Freescale IFC driver to a common driver From: Kumar Gala In-Reply-To: <1390651572-24468-1-git-send-email-prabhakar@freescale.com> Date: Mon, 27 Jan 2014 16:06:48 -0600 Message-Id: <05D64915-8AC8-43CF-97C3-28550A926361@kernel.crashing.org> References: <1390651572-24468-1-git-send-email-prabhakar@freescale.com> To: Prabhakar Kushwaha Cc: Scott Wood , linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Jan 25, 2014, at 6:06 AM, Prabhakar Kushwaha = wrote: > Freescale IFC controller has been used for mpc8xxx. It will be used > for ARM-based SoC as well. This patch moves the driver to = driver/memory > and fix the header file includes. >=20 > Also remove module_platform_driver() and instead call > platform_driver_register() from subsys_initcall() to make sure this = module > has been loaded before MTD partition parsing starts. >=20 > Signed-off-by: Prabhakar Kushwaha > Acked-by: Arnd Bergmann > --- > Based upon = git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git > Branch next >=20 > Changes for v2: > - Move fsl_ifc in driver/memory >=20 > Changes for v3: > - move device tree bindings to memory >=20 > Changes for v4: Rebased to=20 > = git://git.kernel.org/pub/scm/linux/kernel/git/scottwood/linux.git >=20 > Changes for v5:=20 > - Moved powerpc/Kconfig option to driver/memory >=20 > Changes for v6: > - Update Kconfig details >=20 > .../{powerpc =3D> memory-controllers}/fsl/ifc.txt | 0 > arch/powerpc/Kconfig | 4 ---- > arch/powerpc/sysdev/Makefile | 1 - > drivers/memory/Kconfig | 9 +++++++++ > drivers/memory/Makefile | 1 + > {arch/powerpc/sysdev =3D> drivers/memory}/fsl_ifc.c | 8 ++++++-- > drivers/mtd/nand/fsl_ifc_nand.c | 2 +- > .../include/asm =3D> include/linux}/fsl_ifc.h | 0 > 8 files changed, 17 insertions(+), 8 deletions(-) > rename Documentation/devicetree/bindings/{powerpc =3D> = memory-controllers}/fsl/ifc.txt (100%) > rename {arch/powerpc/sysdev =3D> drivers/memory}/fsl_ifc.c (98%) > rename {arch/powerpc/include/asm =3D> include/linux}/fsl_ifc.h (100%) >=20 > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/ifc.txt = b/Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt > similarity index 100% > rename from Documentation/devicetree/bindings/powerpc/fsl/ifc.txt > rename to = Documentation/devicetree/bindings/memory-controllers/fsl/ifc.txt > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index fa39517..91dc43c 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -727,10 +727,6 @@ config FSL_LBC > controller. Also contains some common code used by > drivers for specific local bus peripherals. >=20 > -config FSL_IFC > - bool > - depends on FSL_SOC > - > config FSL_GTM > bool > depends on PPC_83xx || QUICC_ENGINE || CPM2 > diff --git a/arch/powerpc/sysdev/Makefile = b/arch/powerpc/sysdev/Makefile > index f67ac90..afbcc37 100644 > --- a/arch/powerpc/sysdev/Makefile > +++ b/arch/powerpc/sysdev/Makefile > @@ -21,7 +21,6 @@ obj-$(CONFIG_FSL_SOC) +=3D fsl_soc.o = fsl_mpic_err.o > obj-$(CONFIG_FSL_PCI) +=3D fsl_pci.o $(fsl-msi-obj-y) > obj-$(CONFIG_FSL_PMC) +=3D fsl_pmc.o > obj-$(CONFIG_FSL_LBC) +=3D fsl_lbc.o > -obj-$(CONFIG_FSL_IFC) +=3D fsl_ifc.o > obj-$(CONFIG_FSL_GTM) +=3D fsl_gtm.o > obj-$(CONFIG_FSL_85XX_CACHE_SRAM) +=3D fsl_85xx_l2ctlr.o = fsl_85xx_cache_sram.o > obj-$(CONFIG_SIMPLE_GPIO) +=3D simple_gpio.o > diff --git a/drivers/memory/Kconfig b/drivers/memory/Kconfig > index 29a11db..555d26f 100644 > --- a/drivers/memory/Kconfig > +++ b/drivers/memory/Kconfig > @@ -50,4 +50,13 @@ config TEGRA30_MC > analysis, especially for IOMMU/SMMU(System Memory Management > Unit) module. >=20 > +config FSL_IFC > + bool "Freescale Integrated Flash Controller" > + default y > + depends on FSL_SOC minor white space nit (spaces instead of tab) > + help > + This driver is for the Integrated Flash Controller = Controller(IFC)=20 > + module available in Freescale SoCs. This controller allows to = handle flash > + devices such as NOR, NAND, FPGA and ASIC etc > + > endif - k