From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DB83C4360F for ; Thu, 4 Apr 2019 11:26:30 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EE2C20820 for ; Thu, 4 Apr 2019 11:26:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=xenosoft.de header.i=@xenosoft.de header.b="jHein/hr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EE2C20820 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xenosoft.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 44Zgcy557NzDqP1 for ; Thu, 4 Apr 2019 22:26:26 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (helo) smtp.helo=mo6-p00-ob.smtp.rzone.de (client-ip=2a01:238:20a:202:5300::3; helo=mo6-p00-ob.smtp.rzone.de; envelope-from=chzigotzky@xenosoft.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=xenosoft.de Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=xenosoft.de header.i=@xenosoft.de header.b="jHein/hr"; dkim-atps=neutral Received: from mo6-p00-ob.smtp.rzone.de (mo6-p00-ob.smtp.rzone.de [IPv6:2a01:238:20a:202:5300::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 44ZgZC6z9fzDq60 for ; Thu, 4 Apr 2019 22:24:01 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1554377031; s=strato-dkim-0002; d=xenosoft.de; h=In-Reply-To:Date:Message-ID:From:References:To:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=W5/Zvpko5JayqAsOeMB+BbiICMee4WHV9+GYgpybUDc=; b=jHein/hrupb72OoqNKKBfsBjSYYwRH5LnjAVpOKPwhTd/V/FL2lnMMMtC7eIilKuG/ a7+/Pxdtb3Bjrt8ZkII/j48ikgJ0A4jWZETWpjNYrEtpwDYQpsZpvDD1GGYvhMP0saaT 35hGAlBeho9ohEGt7IySd1zAgwD+j0Y+CMPl9Hz9/rXmDahVZWBAXIVET/iB/9qRefE+ 23EHhxWTznIsXcOlqgT5T0+cdX6nI4uzR4HMbnN6Ew8IBlX2UX72ehe+9RDZ4Jzjenig cut8COxhrQ+G9d9vyGQoNgoDFy5G9okeFAIra0Wiujqpu6VKHHZZfBsH30QPZ6O+VLHg 2IZg== X-RZG-AUTH: ":L2QefEenb+UdBJSdRCXu93KJ1bmSGnhMdmOod1DhGM4l4Hio94KKxRySfLxnHfJ+Dkjp5G5MdirQj0WG7CkNjlBPV/3IdB0Je2K2M1gQpcht" X-RZG-CLASS-ID: mo00 Received: from [IPv6:2a02:8109:a400:162c:2057:f49:8d2c:44ac] by smtp.strato.de (RZmta 44.18 AUTH) with ESMTPSA id k00e1ev34BNl3Al (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Thu, 4 Apr 2019 13:23:47 +0200 (CEST) Subject: VLC doesn't play videos anymore since the PowerPC fixes 5.1-3 To: Christophe Leroy , linuxppc-dev@lists.ozlabs.org, Michael Ellerman References: <19FEC425-987D-4B95-AEFD-FF7C05990242@xenosoft.de> <79a9370a-7c4b-80be-adab-6dcf3b0fa6f2@c-s.fr> <0f0403a0-476a-6129-8dc6-866d894c9adc@xenosoft.de> <5726a634-25ca-d267-17fd-af88436edf1f@c-s.fr> <99ff68a4-3aef-47ad-99f8-433b181afe3f@xenosoft.de> <84668be2-94ff-19f6-3b12-56ac545b92bd@c-s.fr> From: Christian Zigotzky Message-ID: <0617ec18-e5a9-c430-3c66-9f1c95a1ef8e@xenosoft.de> Date: Thu, 4 Apr 2019 13:23:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <84668be2-94ff-19f6-3b12-56ac545b92bd@c-s.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: de-DE X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 04 April 2019 at 11:07AM, Christophe Leroy wrote: > > > On 04/04/2019 08:44 AM, Christian Zigotzky wrote: >> On 04 April 2019 at 06:00AM, Christophe Leroy wrote: >>> >>> >>> Le 04/04/2019 à 02:58, Christian Zigotzky a écrit : >>>> On 03 April 2019 at 07:05AM, Christophe Leroy wrote: >>>>> Le 03/04/2019 à 05:52, Christian Zigotzky a écrit : >>>>>> Please test VLC with the RC3 of kernel 5.1. >>>>>> >>>>>> The removing of the PowerPC fixes 5.1-3 has solved the VLC issue. >>>>>> Another user has already confirmed that [1]. This isn’t an April >>>>>> Fool‘s. ;-) >>>>> >>>>> Could you bisect to identify the guilty commit ? >>>>> >>>>> Thanks >>>>> Christophe >>>>> >>>>>> >>>>>> Thanks >>>>>> >>>>>> [1] >>>>>> http://forum.hyperion-entertainment.com/viewtopic.php?f=58&t=4256&start=20#p47561 >>>>>> >>>>>> >>>>> >>>> Hello Christophe, >>>> >>>> I have found the problematic patch. The following patch from the >>>> PowerPC fixes 5.1-3 is responsible for the VLC issue. >>> >>> That change is part of the following commit: >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.1-rc2&id=b5b4453e7912f056da1ca7572574cada32ecb60c >>> >>> >>> Just changing back the type of wtom_clock_sec to 32 bits without >>> changing back the loading instruction is likely to give unexpected >>> results on PPC64. >>> >>> Are you using 32 bits or 64 bits powerpc ? >>> >>> Christophe >> 64-bit kernel + 32-bit userland for example: >> >> - ubuntu MATE 16.04.6 LTS 32-bit PowerPC with a 64-bit kernel >> - Fienix (Debian Sid) 32-bit PowerPC with a 64-bit kernel >> - MATE PowerPC Remix (ubuntu MATE 17.04) 32-bit PowerPC with a 64-bit >> kernel > > Ok, thanks. Can you please try below change: > > diff --git a/arch/powerpc/kernel/vdso32/gettimeofday.S > b/arch/powerpc/kernel/vdso32/gettimeofday.S > index 1e0bc5955a40..afd516b572f8 100644 > --- a/arch/powerpc/kernel/vdso32/gettimeofday.S > +++ b/arch/powerpc/kernel/vdso32/gettimeofday.S > @@ -98,7 +98,7 @@ V_FUNCTION_BEGIN(__kernel_clock_gettime) >       * can be used, r7 contains NSEC_PER_SEC. >       */ > > -    lwz    r5,WTOM_CLOCK_SEC(r9) > +    lwz    r5,(WTOM_CLOCK_SEC+LOPART)(r9) >      lwz    r6,WTOM_CLOCK_NSEC(r9) > >      /* We now have our offset in r5,r6. We create a fake dependency > > > Christophe > Hello Christophe, Your patch works! VLC plays videos without any problems! Thank you! Cheers, Christian