From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x243.google.com (mail-io0-x243.google.com [IPv6:2607:f8b0:4001:c06::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 419PYD3YzHzF0dj for ; Wed, 20 Jun 2018 09:38:40 +1000 (AEST) Received: by mail-io0-x243.google.com with SMTP id r24-v6so1821447ioh.9 for ; Tue, 19 Jun 2018 16:38:40 -0700 (PDT) Subject: Re: Constant ata messages on console with commit 28361c403683 ("libata: add extra internal command") (was Re: [GIT PULL 2/2] libata changes for v4.18-rc1) To: Michael Ellerman , Tejun Heo Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Linus Torvalds , linuxppc-dev References: <20180605190807.GE1351649@devbig577.frc2.facebook.com> <20180605191525.GF1351649@devbig577.frc2.facebook.com> <87bmc8a6qi.fsf@concordia.ellerman.id.au> <87sh5jxmif.fsf@concordia.ellerman.id.au> <87r2l2wdrc.fsf@concordia.ellerman.id.au> From: Jens Axboe Message-ID: <06bd4bf6-92a0-5fce-01b6-9adbc7786513@kernel.dk> Date: Tue, 19 Jun 2018 17:38:34 -0600 MIME-Version: 1.0 In-Reply-To: <87r2l2wdrc.fsf@concordia.ellerman.id.au> Content-Type: text/plain; charset=utf-8 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 6/19/18 5:35 PM, Michael Ellerman wrote: > Jens Axboe writes: >> On 6/19/18 1:29 AM, Michael Ellerman wrote: >>> Jens Axboe writes: >>>> On 6/18/18 1:33 AM, Michael Ellerman wrote: >>>>> Tejun Heo writes: >>>>> ... >>>>>> Jens Axboe (10): >>>>>> libata: introduce notion of separate hardware tags >>>>>> libata: convert core and drivers to ->hw_tag usage >>>>>> libata: bump ->qc_active to a 64-bit type >>>>>> libata: use ata_tag_internal() consistently >>>>>> libata: remove assumption that ATA_MAX_QUEUE - 1 is the max >>>>>> sata_nv: set host can_queue count appropriately >>>>>> libata: add extra internal command >>>>> >>>>> Replying here because I can't find the original mail. >>>>> >>>>> The above commit is causing one of my machines to constantly spew ata >>>>> messages on the console, according to bisect: >>>>> >>>>> # first bad commit: [28361c403683c2b00d4f5e76045f3ccd299bf99d] libata: add extra internal command >>>>> >>>>> To get it to boot I have to also apply: >>>>> >>>>> 88e10092f6a6 ("sata_fsl: use the right type for tag bitshift") >>>>> >>>>> >>>>> The system boots OK and seems fine, except that it's just printing >>>>> multiple of these per second: >>>>> >>>>> ata2: Signature Update detected @ 0 msecs >>>>> ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 300) >>>>> ata2.00: configured for UDMA/100 >>>>> ata2: Signature Update detected @ 0 msecs >>>>> ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 300) >>>>> ata2.00: configured for UDMA/100 >>>>> ata2: Signature Update detected @ 0 msecs >>>>> ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 300) >>>>> ata2.00: configured for UDMA/100 >>>>> ata2: Signature Update detected @ 0 msecs >>>>> ata2: SATA link up 1.5 Gbps (SStatus 113 SControl 300) >>>>> ata2.00: configured for UDMA/100 >>>>> ata2: Signature Update detected @ 0 msecs > ... >> >> Actually, just try this one on top of current -git. > > Yep that fixes it. > > No more message spam, and when I try to mount sr0 it says "no medium". > > I'll have to go into the office to actually put a disc in the drive > to check it's really working, but it seems likely. > > Thanks for debugging it, here's a tested-by if you like: > > Tested-by: Michael Ellerman Thanks, but I packaged it a little differently, see the other series I CC'ed you on. It'll work the same, though. It's in Tejun's tree now, so should end up with Linus some time this week I think. Thanks for reporting and testing the fix! -- Jens Axboe