* [PATCH 7/19] powerpc: interfaces to the hypervisor of Celleb
@ 2007-01-12 1:00 Ishizaki Kou
2007-01-13 12:46 ` Anton Blanchard
0 siblings, 1 reply; 7+ messages in thread
From: Ishizaki Kou @ 2007-01-12 1:00 UTC (permalink / raw)
To: paulus; +Cc: linuxppc-dev
This patch creates Celleb platform dependent files which add
interfaces to call hypervisor.
Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
---
Index: linux-powerpc-git/arch/powerpc/platforms/celleb/hvCall.S
diff -u /dev/null linux-powerpc-git/arch/powerpc/platforms/celleb/hvCall.S:1.5
--- /dev/null Thu Jan 11 22:03:25 2007
+++ linux-powerpc-git/arch/powerpc/platforms/celleb/hvCall.S Wed Jan 10 21:14:43 2007
@@ -0,0 +1,294 @@
+/*
+ * Beat hypervisor call I/F
+ *
+ * (C) Copyright 2007 TOSHIBA CORPORATION
+ *
+ * This code is based on arch/powerpc/platforms/pseries/hvCall.S.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ */
+
+#include <asm/ppc_asm.h>
+
+#define STK_PARM(i) (48 + ((i)-3)*8)
+
+/* Not implemented on Beat, now */
+#define HCALL_INST_PRECALL
+#define HCALL_INST_POSTCALL
+
+ .text
+
+#define HCALL_MEDIUM or 2,2,2
+#define HVSC .long 0x44000022
+#define LOAD_CONST64(r, const) \
+ lis r, ((const)>>48)&0xFFFF; \
+ ori r, r, ((const)>>32)&0xFFFF; \
+ rldicr r, r, 32, 31; \
+ oris r, r, ((const)>>16)&0xFFFF; \
+ ori r, r, ((const)>>0)&0xFFFF
+
+/* Note: takes only 7 input parameters at maximum */
+_GLOBAL(beat_hcall_norets)
+ HMT_MEDIUM
+
+ mfcr r0
+ stw r0,8(r1)
+
+ HCALL_INST_PRECALL
+
+ mr r11,r3
+ mr r3,r4
+ mr r4,r5
+ mr r5,r6
+ mr r6,r7
+ mr r7,r8
+ mr r8,r9
+
+ HVSC /* invoke the hypervisor */
+
+ HCALL_INST_POSTCALL
+
+ lwz r0,8(r1)
+ mtcrf 0xff,r0
+
+ blr /* return r3 = status */
+
+/* Note: takes 8 input parameters at maximum */
+_GLOBAL(beat_hcall_norets8)
+ HMT_MEDIUM
+
+ mfcr r0
+ stw r0,8(r1)
+
+ HCALL_INST_PRECALL
+
+ mr r11,r3
+ mr r3,r4
+ mr r4,r5
+ mr r5,r6
+ mr r6,r7
+ mr r7,r8
+ mr r8,r9
+ ld r10,STK_PARM(r10)(r1)
+
+ HVSC /* invoke the hypervisor */
+
+ HCALL_INST_POSTCALL
+
+ lwz r0,8(r1)
+ mtcrf 0xff,r0
+
+ blr /* return r3 = status */
+
+/* Note: takes only 6 input parameters, 1 output parameters at maximum */
+_GLOBAL(beat_hcall1)
+ HMT_MEDIUM
+
+ mfcr r0
+ stw r0,8(r1)
+
+ HCALL_INST_PRECALL
+
+ std r4,STK_PARM(r4)(r1) /* save ret buffer */
+
+ mr r11,r3
+ mr r3,r5
+ mr r4,r6
+ mr r5,r7
+ mr r6,r8
+ mr r7,r9
+ mr r8,r10
+
+ HVSC /* invoke the hypervisor */
+
+ HCALL_INST_POSTCALL
+
+ ld r12,STK_PARM(r4)(r1)
+ std r4, 0(r12)
+
+ lwz r0,8(r1)
+ mtcrf 0xff,r0
+
+ blr /* return r3 = status */
+
+/* Note: takes only 6 input parameters, 2 output parameters at maximum */
+_GLOBAL(beat_hcall2)
+ HMT_MEDIUM
+
+ mfcr r0
+ stw r0,8(r1)
+
+ HCALL_INST_PRECALL
+
+ std r4,STK_PARM(r4)(r1) /* save ret buffer */
+
+ mr r11,r3
+ mr r3,r5
+ mr r4,r6
+ mr r5,r7
+ mr r6,r8
+ mr r7,r9
+ mr r8,r10
+
+ HVSC /* invoke the hypervisor */
+
+ HCALL_INST_POSTCALL
+
+ ld r12,STK_PARM(r4)(r1)
+ std r4, 0(r12)
+ std r5, 8(r12)
+
+ lwz r0,8(r1)
+ mtcrf 0xff,r0
+
+ blr /* return r3 = status */
+
+/* Note: takes only 6 input parameters, 3 output parameters at maximum */
+_GLOBAL(beat_hcall3)
+ HMT_MEDIUM
+
+ mfcr r0
+ stw r0,8(r1)
+
+ HCALL_INST_PRECALL
+
+ std r4,STK_PARM(r4)(r1) /* save ret buffer */
+
+ mr r11,r3
+ mr r3,r5
+ mr r4,r6
+ mr r5,r7
+ mr r6,r8
+ mr r7,r9
+ mr r8,r10
+
+ HVSC /* invoke the hypervisor */
+
+ HCALL_INST_POSTCALL
+
+ ld r12,STK_PARM(r4)(r1)
+ std r4, 0(r12)
+ std r5, 8(r12)
+ std r6, 16(r12)
+
+ lwz r0,8(r1)
+ mtcrf 0xff,r0
+
+ blr /* return r3 = status */
+
+/* Note: takes only 6 input parameters, 4 output parameters at maximum */
+_GLOBAL(beat_hcall4)
+ HMT_MEDIUM
+
+ mfcr r0
+ stw r0,8(r1)
+
+ HCALL_INST_PRECALL
+
+ std r4,STK_PARM(r4)(r1) /* save ret buffer */
+
+ mr r11,r3
+ mr r3,r5
+ mr r4,r6
+ mr r5,r7
+ mr r6,r8
+ mr r7,r9
+ mr r8,r10
+
+ HVSC /* invoke the hypervisor */
+
+ HCALL_INST_POSTCALL
+
+ ld r12,STK_PARM(r4)(r1)
+ std r4, 0(r12)
+ std r5, 8(r12)
+ std r6, 16(r12)
+ std r7, 24(r12)
+
+ lwz r0,8(r1)
+ mtcrf 0xff,r0
+
+ blr /* return r3 = status */
+
+/* Note: takes only 6 input parameters, 5 output parameters at maximum */
+_GLOBAL(beat_hcall5)
+ HMT_MEDIUM
+
+ mfcr r0
+ stw r0,8(r1)
+
+ HCALL_INST_PRECALL
+
+ std r4,STK_PARM(r4)(r1) /* save ret buffer */
+
+ mr r11,r3
+ mr r3,r5
+ mr r4,r6
+ mr r5,r7
+ mr r6,r8
+ mr r7,r9
+ mr r8,r10
+
+ HVSC /* invoke the hypervisor */
+
+ HCALL_INST_POSTCALL
+
+ ld r12,STK_PARM(r4)(r1)
+ std r4, 0(r12)
+ std r5, 8(r12)
+ std r6, 16(r12)
+ std r7, 24(r12)
+ std r8, 32(r12)
+
+ lwz r0,8(r1)
+ mtcrf 0xff,r0
+
+ blr /* return r3 = status */
+
+/* Note: takes only 6 input parameters, 6 output parameters at maximum */
+_GLOBAL(beat_hcall6)
+ HMT_MEDIUM
+
+ mfcr r0
+ stw r0,8(r1)
+
+ HCALL_INST_PRECALL
+
+ std r4,STK_PARM(r4)(r1) /* save ret buffer */
+
+ mr r11,r3
+ mr r3,r5
+ mr r4,r6
+ mr r5,r7
+ mr r6,r8
+ mr r7,r9
+ mr r8,r10
+
+ HVSC /* invoke the hypervisor */
+
+ HCALL_INST_POSTCALL
+
+ ld r12,STK_PARM(r4)(r1)
+ std r4, 0(r12)
+ std r5, 8(r12)
+ std r6, 16(r12)
+ std r7, 24(r12)
+ std r8, 32(r12)
+ std r9, 40(r12)
+
+ lwz r0,8(r1)
+ mtcrf 0xff,r0
+
+ blr /* return r3 = status */
Index: linux-powerpc-git/arch/powerpc/platforms/celleb/beat_wrapper.h
diff -u /dev/null linux-powerpc-git/arch/powerpc/platforms/celleb/beat_wrapper.h:1.4
--- /dev/null Thu Jan 11 22:03:25 2007
+++ linux-powerpc-git/arch/powerpc/platforms/celleb/beat_wrapper.h Tue Jan 9 16:56:57 2007
@@ -0,0 +1,220 @@
+/*
+ * Beat hypervisor call I/F
+ *
+ * (C) Copyright 2007 TOSHIBA CORPORATION
+ *
+ * This code is based on arch/powerpc/platforms/pseries/plpar_wrapper.h.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ */
+#ifndef BEAT_HCALL
+#include "beat_syscall.h"
+
+/* defined in hvCall.S */
+extern s64 beat_hcall_norets(u64 opcode, ...);
+extern s64 beat_hcall_norets8(u64 opcode, u64 arg1, u64 arg2, u64 arg3,
+ u64 arg4, u64 arg5, u64 arg6, u64 arg7, u64 arg8);
+extern s64 beat_hcall1(u64 opcode, u64 retbuf[1], ...);
+extern s64 beat_hcall2(u64 opcode, u64 retbuf[2], ...);
+extern s64 beat_hcall3(u64 opcode, u64 retbuf[3], ...);
+extern s64 beat_hcall4(u64 opcode, u64 retbuf[4], ...);
+extern s64 beat_hcall5(u64 opcode, u64 retbuf[5], ...);
+extern s64 beat_hcall6(u64 opcode, u64 retbuf[6], ...);
+
+static inline s64 beat_downcount_of_interrupt(u64 plug_id)
+{
+ return beat_hcall_norets(HV_downcount_of_interrupt, plug_id);
+}
+
+static inline s64 beat_set_interrupt_mask(u64 index,
+ u64 val0, u64 val1, u64 val2, u64 val3)
+{
+ return beat_hcall_norets(HV_set_interrupt_mask, index,
+ val0, val1, val2, val3);
+}
+
+static inline s64 beat_destruct_irq_plug(u64 plug_id)
+{
+ return beat_hcall_norets(HV_destruct_irq_plug, plug_id);
+}
+
+static inline s64 beat_construct_and_connect_irq_plug(u64 plug_id,
+ u64 outlet_id)
+{
+ return beat_hcall_norets(HV_construct_and_connect_irq_plug, plug_id,
+ outlet_id);
+}
+
+static inline s64 beat_detect_pending_interrupts(u64 index, u64 *retbuf)
+{
+ return beat_hcall4(HV_detect_pending_interrupts, retbuf, index);
+}
+
+static inline s64 beat_pause(u64 style)
+{
+ return beat_hcall_norets(HV_pause, style);
+}
+
+static inline s64 beat_read_htab_entries(u64 htab_id, u64 index, u64 *retbuf)
+{
+ return beat_hcall5(HV_read_htab_entries, retbuf, htab_id, index);
+}
+
+static inline s64 beat_insert_htab_entry(u64 htab_id, u64 group,
+ u64 bitmask, u64 hpte_v, u64 hpte_r, u64 *slot)
+{
+ u64 dummy[3];
+ s64 ret;
+
+ ret = beat_hcall3(HV_insert_htab_entry, dummy, htab_id, group,
+ bitmask, hpte_v, hpte_r);
+ *slot = dummy[0];
+ return ret;
+}
+
+static inline s64 beat_write_htab_entry(u64 htab_id, u64 slot,
+ u64 hpte_v, u64 hpte_r, u64 mask_v, u64 mask_r,
+ u64 *ret_v, u64 *ret_r)
+{
+ u64 dummy[2];
+ s64 ret;
+
+ ret = beat_hcall2(HV_write_htab_entry, dummy, htab_id, slot,
+ hpte_v, hpte_r, mask_v, mask_r);
+ *ret_v = dummy[0];
+ *ret_r = dummy[1];
+ return ret;
+}
+
+static inline void beat_shutdown_logical_partition(u64 code)
+{
+ (void)beat_hcall_norets(HV_shutdown_logical_partition, code);
+}
+
+static inline s64 beat_rtc_write(u64 time_from_epoch)
+{
+ return beat_hcall_norets(HV_rtc_write, time_from_epoch);
+}
+
+static inline s64 beat_rtc_read(u64 *time_from_epoch)
+{
+ u64 dummy[1];
+ s64 ret;
+
+ ret = beat_hcall1(HV_rtc_read, dummy);
+ *time_from_epoch = dummy[0];
+ return ret;
+}
+
+#define BEAT_NVRW_CNT (sizeof(u64) * 6)
+
+static inline s64 beat_eeprom_write(u64 index, u64 length, u8 *buffer)
+{
+ u64 b[6];
+
+ if (length > BEAT_NVRW_CNT)
+ return -1;
+ memcpy(b, buffer, sizeof(b));
+ return beat_hcall_norets8(HV_eeprom_write, index, length,
+ b[0], b[1], b[2], b[3], b[4], b[5]);
+}
+
+static inline s64 beat_eeprom_read(u64 index, u64 length, u8 *buffer)
+{
+ u64 b[6];
+ s64 ret;
+
+ if (length > BEAT_NVRW_CNT)
+ return -1;
+ ret = beat_hcall6(HV_eeprom_read, b, index, length);
+ memcpy(buffer, b, length);
+ return ret;
+}
+
+static inline s64 beat_set_dabr(u64 value, u64 style)
+{
+ return beat_hcall_norets(HV_set_dabr, value, style);
+}
+
+static inline s64 beat_get_characters_from_console(u64 termno, u64 *len,
+ u8 *buffer)
+{
+ u64 dummy[3];
+ s64 ret;
+
+ ret = beat_hcall3(HV_get_characters_from_console, dummy, termno, len);
+ *len = dummy[0];
+ memcpy(buffer, dummy + 1, *len);
+ return ret;
+}
+
+static inline s64 beat_put_characters_to_console(u64 termno, u64 len,
+ u8 *buffer)
+{
+ u64 b[2];
+
+ memcpy(b, buffer, len);
+ return beat_hcall_norets(HV_put_characters_to_console, termno, len, b[0], b[1]);
+}
+
+static inline s64 beat_get_spe_privileged_state_1_registers(
+ u64 id, u64 offsetof, u64 *value)
+{
+ u64 dummy[1];
+ s64 ret;
+
+ ret = beat_hcall1(HV_get_spe_privileged_state_1_registers, dummy, id,
+ offsetof);
+ *value = dummy[0];
+ return ret;
+}
+
+static inline s64 beat_set_irq_mask_for_spe(u64 id, u64 class, u64 mask)
+{
+ return beat_hcall_norets(HV_set_irq_mask_for_spe, id, class, mask);
+}
+
+static inline s64 beat_clear_interrupt_status_of_spe(u64 id, u64 class,
+ u64 mask)
+{
+ return beat_hcall_norets(HV_clear_interrupt_status_of_spe,
+ id, class, mask);
+}
+
+static inline s64 beat_set_spe_privileged_state_1_registers(
+ u64 id, u64 offsetof, u64 value)
+{
+ return beat_hcall_norets(HV_set_spe_privileged_state_1_registers,
+ id, offsetof, value);
+}
+
+static inline s64 beat_get_interrupt_status_of_spe(u64 id, u64 class, u64 *val)
+{
+ u64 dummy[1];
+ s64 ret;
+
+ ret = beat_hcall1(HV_get_interrupt_status_of_spe, dummy, id, class);
+ *val = dummy[0];
+ return ret;
+}
+
+static inline s64 beat_put_iopte(u64 ioas_id, u64 io_addr, u64 real_addr,
+ u64 ioid, u64 flags)
+{
+ return beat_hcall_norets(HV_put_iopte, ioas_id, io_addr, real_addr,
+ ioid, flags);
+}
+
+#endif
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 7/19] powerpc: interfaces to the hypervisor of Celleb
2007-01-12 1:00 [PATCH 7/19] powerpc: interfaces to the hypervisor of Celleb Ishizaki Kou
@ 2007-01-13 12:46 ` Anton Blanchard
2007-01-13 15:53 ` Segher Boessenkool
2007-01-15 16:07 ` Will Schmidt
0 siblings, 2 replies; 7+ messages in thread
From: Anton Blanchard @ 2007-01-13 12:46 UTC (permalink / raw)
To: Ishizaki Kou; +Cc: linuxppc-dev, paulus
Hi,
Just a few suggestions.
> +#define HCALL_MEDIUM or 2,2,2
Doesnt look like this is used.
> +#define HVSC .long 0x44000022
Could you pick this up from the define in include/asm-powerpc instead?
> +#define LOAD_CONST64(r, const) \
> + lis r, ((const)>>48)&0xFFFF; \
> + ori r, r, ((const)>>32)&0xFFFF; \
> + rldicr r, r, 32, 31; \
> + oris r, r, ((const)>>16)&0xFFFF; \
> + ori r, r, ((const)>>0)&0xFFFF
It doesnt look like this is used either.
Anton
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 7/19] powerpc: interfaces to the hypervisor of Celleb
2007-01-13 12:46 ` Anton Blanchard
@ 2007-01-13 15:53 ` Segher Boessenkool
2007-01-13 17:53 ` Geoff Levand
2007-01-15 16:07 ` Will Schmidt
1 sibling, 1 reply; 7+ messages in thread
From: Segher Boessenkool @ 2007-01-13 15:53 UTC (permalink / raw)
To: Anton Blanchard; +Cc: linuxppc-dev, paulus
>> +#define HVSC .long 0x44000022
>
> Could you pick this up from the define in include/asm-powerpc instead?
Or just write "sc 1", everyone should have new enough binutils
by now.
Segher
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 7/19] powerpc: interfaces to the hypervisor of Celleb
2007-01-13 15:53 ` Segher Boessenkool
@ 2007-01-13 17:53 ` Geoff Levand
2007-01-13 20:57 ` Segher Boessenkool
0 siblings, 1 reply; 7+ messages in thread
From: Geoff Levand @ 2007-01-13 17:53 UTC (permalink / raw)
To: Segher Boessenkool; +Cc: linuxppc-dev, paulus, Anton Blanchard
Segher Boessenkool wrote:
>>> +#define HVSC .long 0x44000022
>>
>> Could you pick this up from the define in include/asm-powerpc instead?
>
> Or just write "sc 1", everyone should have new enough binutils
> by now.
The option to 'sc' came in binutils-2.17, but I from what I understand, debian
stable doesn't have it, so I used a similar construction for ps3.
-Geoff
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 7/19] powerpc: interfaces to the hypervisor of Celleb
2007-01-13 17:53 ` Geoff Levand
@ 2007-01-13 20:57 ` Segher Boessenkool
0 siblings, 0 replies; 7+ messages in thread
From: Segher Boessenkool @ 2007-01-13 20:57 UTC (permalink / raw)
To: Geoff Levand; +Cc: linuxppc-dev, paulus, Anton Blanchard
>> Or just write "sc 1", everyone should have new enough binutils
>> by now.
>
> The option to 'sc' came in binutils-2.17, but I from what I
> understand, debian
> stable doesn't have it, so I used a similar construction for ps3.
Oh sorry, I thought it was in 2.16 for a long time already. If
Debian doesn't have it, well sigh, let's use .long 0x44000022
for a bit longer :-(
Segher
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 7/19] powerpc: interfaces to the hypervisor of Celleb
2007-01-13 12:46 ` Anton Blanchard
2007-01-13 15:53 ` Segher Boessenkool
@ 2007-01-15 16:07 ` Will Schmidt
2007-01-16 11:28 ` Ishizaki Kou
1 sibling, 1 reply; 7+ messages in thread
From: Will Schmidt @ 2007-01-15 16:07 UTC (permalink / raw)
To: Anton Blanchard; +Cc: linuxppc-dev, paulus
On Sat, 2007-13-01 at 23:46 +1100, Anton Blanchard wrote:
> Hi,
>
> Just a few suggestions.
>
> > +#define HCALL_MEDIUM or 2,2,2
>
> Doesnt look like this is used.
seconded. that #define is identical to HMT_MEDIUM out of ppc_asm.h. I
notice that HMT_MEDIUM is actually used throughout this patch, so most
of the way there already.
> > +#define HVSC .long 0x44000022
>
> Could you pick this up from the define in include/asm-powerpc instead?
"#include <asm/hvcall.h>" should do it.
>
> > +#define LOAD_CONST64(r, const) \
> > + lis r, ((const)>>48)&0xFFFF; \
> > + ori r, r, ((const)>>32)&0xFFFF; \
> > + rldicr r, r, 32, 31; \
> > + oris r, r, ((const)>>16)&0xFFFF; \
> > + ori r, r, ((const)>>0)&0xFFFF
>
> It doesnt look like this is used either.
>
> Anton
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 7/19] powerpc: interfaces to the hypervisor of Celleb
2007-01-15 16:07 ` Will Schmidt
@ 2007-01-16 11:28 ` Ishizaki Kou
0 siblings, 0 replies; 7+ messages in thread
From: Ishizaki Kou @ 2007-01-16 11:28 UTC (permalink / raw)
To: anton, will_schmidt; +Cc: linuxppc-dev, paulus
Hello everyone,
> > Just a few suggestions.
Thank you for your comments.
> > > +#define HCALL_MEDIUM or 2,2,2
> >
> > Doesnt look like this is used.
>
> seconded. that #define is identical to HMT_MEDIUM out of ppc_asm.h. I
> notice that HMT_MEDIUM is actually used throughout this patch, so most
> of the way there already.
We'll remove it.
<asm/ppc_asm.h> is already included so we don't have to have
HMT_MEDIUM or HCALL_MEDIUM defintion in that file.
> > > +#define HVSC .long 0x44000022
> >
> > Could you pick this up from the define in include/asm-powerpc instead?
>
> "#include <asm/hvcall.h>" should do it.
As Geoff-san said, "sc 1" is not supported in Debian or our own assembler,
so we have to keep it.
We think <asm/hvcall.h> is only for IBM's hypervisor, so we don't want
to include <asm/hvcall.h> only to get HVSC definition in our hvCall.S;
so we will keep HVSC definition here.
> > > +#define LOAD_CONST64(r, const) \
> > > + lis r, ((const)>>48)&0xFFFF; \
> > > + ori r, r, ((const)>>32)&0xFFFF; \
> > > + rldicr r, r, 32, 31; \
> > > + oris r, r, ((const)>>16)&0xFFFF; \
> > > + ori r, r, ((const)>>0)&0xFFFF
> >
> > It doesnt look like this is used either.
We'll remove it.
Best regards,
Kou Ishizaki
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2007-01-16 11:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-12 1:00 [PATCH 7/19] powerpc: interfaces to the hypervisor of Celleb Ishizaki Kou
2007-01-13 12:46 ` Anton Blanchard
2007-01-13 15:53 ` Segher Boessenkool
2007-01-13 17:53 ` Geoff Levand
2007-01-13 20:57 ` Segher Boessenkool
2007-01-15 16:07 ` Will Schmidt
2007-01-16 11:28 ` Ishizaki Kou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).