arch/ppc/82xx_io/uart.c bug found

arch/ppc/82xx_io/uart.c bug found

[Wojciech Kromer]

here is orignal uart.c

#ifdef SCC_CONSOLE
                                switch (state->smc_scc_num) {
                                case 0:
                                        page = CPM_CR_SCC1_PAGE;
                                        sblock = CPM_CR_SCC1_SBLOCK;
                                        break;
                                case 1:
                                        page = CPM_CR_SCC2_PAGE;
                                        sblock = CPM_CR_SCC2_SBLOCK;
                                        break;
                                case 2:
                                        page = CPM_CR_SCC3_PAGE;
                                        sblock = CPM_CR_SCC3_SBLOCK;
                                        break;
                                }
....


 so SCC4 is unusable, here is missing code:

                                case 3:
                                        page = CPM_CR_SCC4_PAGE;
                                        sblock = CPM_CR_SCC4_SBLOCK;
                                        break;
                                }

Re: arch/ppc/82xx_io/uart.c bug found

[Dan Malek]

On Feb 13, 2006, at 8:51 AM, Wojciech Kromer wrote:

> here is orignal uart.c

Three things....

One, this code is obsolete and isn't used any more.
Two, it's not a bug, just a feature enhancement.
Three, if you want us to actually do something about
this I need a real patch against an up to date
public source tree and indication it was actually
tested on some platform.

Thanks.

	-- Dan

Re: arch/ppc/82xx_io/uart.c bug found

[Wojciech Kromer]

>Three things....
>
>One, this code is obsolete and isn't used any more.
>  
>
It's in latest linuxppc_2_4_devel from denx.de CVS.

>Two, it's not a bug, just a feature enhancement.
>  
>
OK.

>Three, if you want us to actually do something about
>this I need a real patch against an up to date
>public source tree and indication it was actually
>tested on some platform.
>  
>
I'm currently using CVS version from denx.de,
there are lot of features I'm using.

Just use this info as an information, not offcial bug note.
I spend few days finding it.