* arch/ppc/82xx_io/uart.c bug found
@ 2006-02-13 13:51 Wojciech Kromer
2006-02-13 16:14 ` Dan Malek
0 siblings, 1 reply; 3+ messages in thread
From: Wojciech Kromer @ 2006-02-13 13:51 UTC (permalink / raw)
To: linuxppc-embedded
here is orignal uart.c
#ifdef SCC_CONSOLE
switch (state->smc_scc_num) {
case 0:
page = CPM_CR_SCC1_PAGE;
sblock = CPM_CR_SCC1_SBLOCK;
break;
case 1:
page = CPM_CR_SCC2_PAGE;
sblock = CPM_CR_SCC2_SBLOCK;
break;
case 2:
page = CPM_CR_SCC3_PAGE;
sblock = CPM_CR_SCC3_SBLOCK;
break;
}
....
so SCC4 is unusable, here is missing code:
case 3:
page = CPM_CR_SCC4_PAGE;
sblock = CPM_CR_SCC4_SBLOCK;
break;
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: arch/ppc/82xx_io/uart.c bug found
2006-02-13 13:51 arch/ppc/82xx_io/uart.c bug found Wojciech Kromer
@ 2006-02-13 16:14 ` Dan Malek
2006-02-20 7:57 ` Wojciech Kromer
0 siblings, 1 reply; 3+ messages in thread
From: Dan Malek @ 2006-02-13 16:14 UTC (permalink / raw)
To: Wojciech Kromer; +Cc: linuxppc-embedded
On Feb 13, 2006, at 8:51 AM, Wojciech Kromer wrote:
> here is orignal uart.c
Three things....
One, this code is obsolete and isn't used any more.
Two, it's not a bug, just a feature enhancement.
Three, if you want us to actually do something about
this I need a real patch against an up to date
public source tree and indication it was actually
tested on some platform.
Thanks.
-- Dan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: arch/ppc/82xx_io/uart.c bug found
2006-02-13 16:14 ` Dan Malek
@ 2006-02-20 7:57 ` Wojciech Kromer
0 siblings, 0 replies; 3+ messages in thread
From: Wojciech Kromer @ 2006-02-20 7:57 UTC (permalink / raw)
Cc: linuxppc-embedded
>Three things....
>
>One, this code is obsolete and isn't used any more.
>
>
It's in latest linuxppc_2_4_devel from denx.de CVS.
>Two, it's not a bug, just a feature enhancement.
>
>
OK.
>Three, if you want us to actually do something about
>this I need a real patch against an up to date
>public source tree and indication it was actually
>tested on some platform.
>
>
I'm currently using CVS version from denx.de,
there are lot of features I'm using.
Just use this info as an information, not offcial bug note.
I spend few days finding it.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-02-20 7:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-13 13:51 arch/ppc/82xx_io/uart.c bug found Wojciech Kromer
2006-02-13 16:14 ` Dan Malek
2006-02-20 7:57 ` Wojciech Kromer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).