From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Michael Ellerman <mpe@ellerman.id.au>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] powerpc/ptdump: Fix DEBUG_WX since generic ptdump conversion
Date: Fri, 3 Dec 2021 12:55:09 +0000 [thread overview]
Message-ID: <085c3f0b-9162-09d9-34be-387f43f0a45a@csgroup.eu> (raw)
In-Reply-To: <20211203124112.2912562-1-mpe@ellerman.id.au>
Le 03/12/2021 à 13:41, Michael Ellerman a écrit :
> In note_prot_wx() we bail out without reporting anything if
> CONFIG_PPC_DEBUG_WX is disabled.
>
> But CONFIG_PPC_DEBUG_WX was removed in the conversion to generic ptdump,
> we now need to use CONFIG_DEBUG_WX instead.
>
> Fixes: e084728393a5 ("powerpc/ptdump: Convert powerpc to GENERIC_PTDUMP")
> Cc: stable@vger.kernel.org # v5.15+
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
Oops ... my mistake.
Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> arch/powerpc/mm/ptdump/ptdump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/mm/ptdump/ptdump.c b/arch/powerpc/mm/ptdump/ptdump.c
> index 031956d0ee84..be120e09aa3e 100644
> --- a/arch/powerpc/mm/ptdump/ptdump.c
> +++ b/arch/powerpc/mm/ptdump/ptdump.c
> @@ -183,7 +183,7 @@ static void note_prot_wx(struct pg_state *st, unsigned long addr)
> {
> pte_t pte = __pte(st->current_flags);
>
> - if (!IS_ENABLED(CONFIG_PPC_DEBUG_WX) || !st->check_wx)
> + if (!IS_ENABLED(CONFIG_DEBUG_WX) || !st->check_wx)
> return;
>
> if (!pte_write(pte) || !pte_exec(pte))
>
next prev parent reply other threads:[~2021-12-03 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 12:41 [PATCH] powerpc/ptdump: Fix DEBUG_WX since generic ptdump conversion Michael Ellerman
2021-12-03 12:55 ` Christophe Leroy [this message]
2021-12-26 21:51 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=085c3f0b-9162-09d9-34be-387f43f0a45a@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox