From: Tyrel Datwyler <tyreld@linux.ibm.com>
To: Haowen Bai <baihaowen@meizu.com>,
Russell Currey <ruscur@russell.cc>,
"Oliver O'Halloran" <oohall@gmail.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/eeh: Drop redundant spinlock initialization
Date: Tue, 10 May 2022 11:54:49 -0700 [thread overview]
Message-ID: <08d9470c-20db-52b8-7015-84f0ed29ad0c@linux.ibm.com> (raw)
In-Reply-To: <1652176394-4331-1-git-send-email-baihaowen@meizu.com>
On 5/10/22 02:53, Haowen Bai wrote:
> slot_errbuf_lock has declared and initialized by DEFINE_SPINLOCK,
> so we don't need to spin_lock_init again, drop it.
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
> arch/powerpc/platforms/pseries/eeh_pseries.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/powerpc/platforms/pseries/eeh_pseries.c b/arch/powerpc/platforms/pseries/eeh_pseries.c
> index f9af879c0222..77b476093e06 100644
> --- a/arch/powerpc/platforms/pseries/eeh_pseries.c
> +++ b/arch/powerpc/platforms/pseries/eeh_pseries.c
> @@ -848,7 +848,6 @@ static int __init eeh_pseries_init(void)
> }
>
> /* Initialize error log lock and size */
Update the comment, or just drop it entirely?
-Tyrel
> - spin_lock_init(&slot_errbuf_lock);
> eeh_error_buf_size = rtas_token("rtas-error-log-max");
> if (eeh_error_buf_size == RTAS_UNKNOWN_SERVICE) {
> pr_info("%s: unknown EEH error log size\n",
next prev parent reply other threads:[~2022-05-10 18:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-10 9:53 [PATCH] powerpc/eeh: Drop redundant spinlock initialization Haowen Bai
2022-05-10 18:54 ` Tyrel Datwyler [this message]
2022-05-11 1:27 ` [PATCH V2] " Haowen Bai
2022-05-24 11:09 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08d9470c-20db-52b8-7015-84f0ed29ad0c@linux.ibm.com \
--to=tyreld@linux.ibm.com \
--cc=baihaowen@meizu.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=oohall@gmail.com \
--cc=paulus@samba.org \
--cc=ruscur@russell.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).