From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>,
Nicholas Piggin <npiggin@gmail.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Sayali Patil <sayalip@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Cc: stable@vger.kernel.org, Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: [PATCH v2] powerpc/uaccess: correct check for CONFIG_PPC_E500 in mask_user_address()
Date: Tue, 16 Jun 2026 07:34:44 +0200 [thread overview]
Message-ID: <095d4604-b3d7-492e-b119-2bedcb63217e@kernel.org> (raw)
In-Reply-To: <20260615233729.29386-1-enelsonmoore@gmail.com>
Le 16/06/2026 à 01:37, Ethan Nelson-Moore a écrit :
> mask_user_address() incorrectly checks for CONFIG_E500 instead of
> CONFIG_PPC_E500, causing mask_user_address_isel() to not be used on
> E500 hardware. Fix the check to use the correct name.
>
> Fixes: 861574d51bbd ("powerpc/uaccess: Implement masked user access")
> Cc: stable@vger.kernel.org # 7.0+
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Reviewed-by: Christophe Leroy (CS GROUP) <chleroy@kernel.org>
> ---
> Changes in v2: Correct explanation and Fixes tag (thanks Christophe)
>
> arch/powerpc/include/asm/uaccess.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/uaccess.h b/arch/powerpc/include/asm/uaccess.h
> index e98c628e3899..619270bb7380 100644
> --- a/arch/powerpc/include/asm/uaccess.h
> +++ b/arch/powerpc/include/asm/uaccess.h
> @@ -511,7 +511,7 @@ static inline void __user *mask_user_address(const void __user *ptr)
>
> if (IS_ENABLED(CONFIG_PPC64))
> return mask_user_address_simple(ptr);
> - if (IS_ENABLED(CONFIG_E500))
> + if (IS_ENABLED(CONFIG_PPC_E500))
> return mask_user_address_isel(ptr);
> if (TASK_SIZE <= UL(SZ_2G) && border >= UL(SZ_2G))
> return mask_user_address_simple(ptr);
prev parent reply other threads:[~2026-06-16 5:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 23:37 [PATCH v2] powerpc/uaccess: correct check for CONFIG_PPC_E500 in mask_user_address() Ethan Nelson-Moore
2026-06-16 5:34 ` Christophe Leroy (CS GROUP) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=095d4604-b3d7-492e-b119-2bedcb63217e@kernel.org \
--to=chleroy@kernel.org \
--cc=enelsonmoore@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=sayalip@linux.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox